Auto-approver: pathless template with unique name
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Jeroen T. Vermeulen |
Bug Description
One of the time-wasters with import queue review is template uploads without directory paths. For example, a known template might be "plugin/plugin.pot" after which the user uploads "plugin.pot".
When the auto-approver sees a template upload with no directory path, it could do a base filename match. When exactly one current template matches (in this case, "plugin.pot"), then that's the right template and the upload can be approved.
I can't come up with any legitimate scenarios where this would disappoint. It saves time in the case where maintainers sometimes upload tarballs, and sometimes individual templates without browsing to the template's UI first. This may actually increase, relative to total manual approvals, as more people use bzr imports for day-to-day translations management but do the occasional manual upload.
Related branches
- Gavin Panella (community): Approve
-
Diff: 165 lines4 files modifiedlib/lp/translations/interfaces/potemplate.py (+12/-0)
lib/lp/translations/model/potemplate.py (+14/-1)
lib/lp/translations/model/translationimportqueue.py (+18/-2)
lib/lp/translations/tests/test_autoapproval.py (+64/-0)
description: | updated |
tags: | added: rosetta-imports |
tags: |
added: import-queue removed: rosetta-imports |
Changed in rosetta: | |
status: | New → Triaged |
importance: | Undecided → High |
importance: | High → Low |
Changed in rosetta: | |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
milestone: | none → 3.1.10 |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
This bug was mentioned in stable r9761 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 9761>