Edit icon for merge proposals status should be inline
Bug #435197 reported by
Martin Albisetti
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Paul Hummer | ||
Bug Description
In the conversion to 3.0, the link to change the status of a merge proposal has been moved into the global actions menu. This is not a global action, and should be restored to be besides the actual status.
The rule for 3.0 is that anything that is displayed and can be edited, should have the edit icon next to it.
Related branches
lp://qastaging/~rockstar/launchpad/fix-bmp-links
- Michael Hudson-Doyle: Approve
-
Diff: 107 lines3 files modifiedlib/lp/code/browser/branchmergeproposal.py (+6/-5)
lib/lp/code/stories/branches/xx-branch-merge-proposals.txt (+5/-5)
lib/lp/code/templates/branchmergeproposal-pagelet-summary.pt (+10/-0)
| tags: | added: post-3-ui-cleanup |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Paul Hummer (rockstar) |
| milestone: | none → 3.1.10 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #1 |
Revision history for this message
| Martin Albisetti (beuno) wrote | #2 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #3 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm happy to do this work, but I guess I'm confused about what a "global action" is then. My understanding was that because it operated on the branch merge proposal itself, it was a "global action" Martin, could you please explain?