Check for mis-approved files
Bug #436426 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Jeroen T. Vermeulen | ||
Bug Description
As a result of bug 435699, we just had a series of uploads approved for the right package name and template name, but the wrong distroseries. It would help if the importer checked for this sort of mismatch, and raised an error.
This may also be a good time to start generating oopses instead of relying on logging.
Related branches
lp://qastaging/~jtv/launchpad/bug-436426-2
- Jeroen T. Vermeulen (community): Abstain
- Edwin Grubbs (community): Approve (code)
-
Diff: 814 lines9 files modifiedconfigs/development/launchpad-lazr.conf (+4/-0)
configs/testrunner/launchpad-lazr.conf (+4/-0)
cronscripts/rosetta-poimport.py (+4/-26)
lib/canonical/config/schema-lazr.conf (+7/-1)
lib/canonical/launchpad/javascript/translations/translations.js (+4/-2)
lib/lp/translations/doc/poimport.txt (+20/-9)
lib/lp/translations/doc/translationimportqueue.txt (+60/-33)
lib/lp/translations/scripts/po_import.py (+161/-160)
lib/lp/translations/scripts/tests/test_translations_import.py (+110/-0)
| Changed in rosetta: | |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Changed in rosetta: | |
| milestone: | none → 3.1.10 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in devel 9612