Remove owner permissions check from POTemplate.newPOFile
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Jeroen T. Vermeulen |
Bug Description
POFiles are created through POTemplate.
This triggers a permissions check that has tripped up us several times on database permissions for rarer cases. It'd be more transparent if this check were done at the call site.
Moreover, POFile.owner doesn't seem to be used for anything meaningful, so we may not need it at all. The only thing it seems to do is give the owner editing permissions—which in the current code they must have had anyway to have become the owner in the first place. We could drop it, or allow it to be NULL and make that the default.
Related branches
- Abel Deuring (community): Approve (code)
-
Diff: 357 lines (+120/-67)10 files modifieddatabase/schema/security.cfg (+25/-23)
lib/lp/testing/factory.py (+0/-1)
lib/lp/translations/browser/potemplate.py (+6/-5)
lib/lp/translations/interfaces/pofile.py (+3/-0)
lib/lp/translations/interfaces/potemplate.py (+1/-2)
lib/lp/translations/model/pofile.py (+13/-16)
lib/lp/translations/model/potemplate.py (+5/-11)
lib/lp/translations/model/translationimportqueue.py (+3/-2)
lib/lp/translations/scripts/tests/test_message_sharing_migration.py (+3/-1)
lib/lp/translations/tests/test_autoapproval.py (+61/-6)
Changed in rosetta: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: tech-debt |
Changed in rosetta: | |
importance: | Low → Medium |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
milestone: | none → 3.1.11 |
Changed in rosetta: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
The approver is currently failing again because of this: bug 487590.