Launchpad itself

"Copy packages" link has edit icon

Bug #470430 reported by Matthew Paul Thomas
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

On a PPA packages page such as <https://launchpad.net/~gilir/+archive/updates/+packages>, the "Copy packages" link has an edit icon. This doesn't make sense, because you're not editing anything.

Related branches

lp://qastaging/~wgrant/launchpad/trivialities
Curtis Hovey (community): Approve (code)
Diff: 462 lines (+73/-60)
20 files modified
lib/canonical/launchpad/icing/sprite.css.in (+4/-0)
lib/lp/app/templates/launchpad-notfound.pt (+1/-1)
lib/lp/bugs/javascript/bugtarget_portlet_bugtags.js (+5/-5)
lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.html (+1/-1)
lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js (+18/-18)
lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt (+1/-1)
lib/lp/bugs/templates/bugtask-edit-form.pt (+1/-3)
lib/lp/configure.zcml (+0/-1)
lib/lp/registry/browser/product.py (+4/-4)
lib/lp/registry/templates/team-mailinglist-moderate.pt (+0/-1)
lib/lp/soyuz/adapters/notification.py (+6/-3)
lib/lp/soyuz/adapters/tests/test_notification.py (+4/-3)
lib/lp/soyuz/browser/archive.py (+2/-2)
lib/lp/soyuz/emailtemplates/ppa-upload-accepted.txt (+1/-1)
lib/lp/soyuz/emailtemplates/ppa-upload-rejection.txt (+1/-1)
lib/lp/soyuz/scripts/queue.py (+2/-1)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+5/-3)
lib/lp/soyuz/scripts/tests/test_queue.py (+15/-0)
lib/lp/soyuz/stories/ppa/xx-delete-packages.txt (+2/-4)
lib/lp/soyuz/templates/packagepublishing-details.pt (+0/-7)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

What icon would you expect to see instead?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Ideally, I'd expect "Copy packages to another PPA" to be an expandable section under the package list, in which case its icon would be the normal ▷ expander icon.

Failing that, I would expect it to use a dedicated icon indicating copied packages, similar to the "Mark as duplicate" icon.

Vikram Dhillon (dhillon-v10)
Changed in soyuz:
status: New → Confirmed
tags: added: ui
Julian Edwards (julian-edwards)
tags: added: trivial
Changed in soyuz:
status: Confirmed → Triaged
importance: Undecided → Low
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14779 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14779>.

Changed in launchpad:
assignee: nobody → William Grant (wgrant)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.