Commit message UI needs re-working
Bug #479526 reported by
Martin Albisetti
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Tim Penhey | ||
Bug Description
The commit message UI on merge proposals is confusing.
We need to re-work it. We shouldn't show edit icons for objects that are empty, so in this case the interaction would be something like:
(+) Set commit message -> inline editor comes up -> save -> profit
Once there is a commit message, the edit button is there.
And some bottom padding pretty please! :)
Related branches
lp://qastaging/~thumper/launchpad/edit-commit-msg-link
- Francis J. Lacoste (community): Approve (release-critical)
- Māris Fogels (community): Approve (js)
- Michael Hudson-Doyle: Abstain
- Martin Albisetti (community): Approve (ui)
- Guilherme Salgado: Pending requested
-
Diff: 316 lines (+120/-27)7 files modifiedlib/canonical/launchpad/javascript/code/codereview.js (+66/-3)
lib/canonical/widgets/lazrjs.py (+7/-2)
lib/lp/app/templates/base-layout-macros.pt (+3/-1)
lib/lp/code/browser/branchmergeproposal.py (+5/-5)
lib/lp/code/stories/branches/xx-branch-merge-proposals.txt (+4/-3)
lib/lp/code/templates/branchmergeproposal-index.pt (+32/-10)
lib/lp/code/windmill/tests/test_branch_merge_proposal.py (+3/-3)
Revision history for this message
| Brad Crittenden (bac) wrote | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 3.1.11 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| Changed in launchpad-code: | |
| milestone: | 3.1.11 → 3.1.12 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Also note that the in-line editor controls are broken for web-kit based browsers. The controls are placed incorrectly and occlude the entry area. See the attached screen shot.