Launchpad itself

OOPS deleting a branch

Bug #480000 reported by Diogo Matsubara
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Tim Penhey
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

As seen in OOPS-1409G2556 a CannotDeleteBranch: Cannot delete branch: ~gustavo-grahal/z3ext.blogger/z3ext.blogger-pt-br exception was raised

The traceback shown is very similar to the one in bug 211394. Maybe some other object different than series is still linked to the branch in question?

Related branches

lp://qastaging/~thumper/launchpad/fix-deletion-syncUpdate
Jonathan Lange (community): Approve
Diff: 105 lines (+16/-17)
2 files modified
lib/lp/code/model/branch.py (+3/-5)
lib/lp/code/model/tests/test_branch.py (+13/-12)
Diogo Matsubara (matsubara)
tags: added: oops
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Just a WAG, but I wonder if you load the +delete page as a user that can delete the branch, then a series link that you can't delete is added. then you click delete, this might happen.

Revision history for this message
Tim Penhey (thumper) wrote :

I agree with Michael. It seems to be a race condition between when the user has loaded the +delete page, and when they click on the delete button on the bottom. During that time someone else has linked the branch as the primary branch for the series.

We should catch the error, and not oops.

Changed in launchpad-code:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Diogo Matsubara (matsubara) wrote :

I duped bug 493692 against this one as the traceback is very similar. The user that reported bug 493692 mentioned that his branch is linked to export translations. Maybe that's the cause?

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 480000] Re: OOPS deleting a branch

On Fri, 11 Dec 2009 08:48:37 Diogo Matsubara wrote:
> I duped bug 493692 against this one as the traceback is very similar.
> The user that reported bug 493692 mentioned that his branch is linked to
> export translations. Maybe that's the cause?

May well be. I expect there is a relationship there that isn't being
destroyed.

Tim

Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → Fix Committed
assignee: nobody → Tim Penhey (thumper)
milestone: none → 10.09
Ursula Junque (ursinha)
tags: added: qa-needstesting
Tim Penhey (thumper)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.