Launchpad itself

Unsubscribe icons in portlets may not handle onclick events

Bug #482379 reported by Deryck Hodge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Deryck Hodge
Launchpad itself 3.1.11

Bug Description

Because the duplicate subscribers portlet is loaded via XHR now, the unsubscribe icons in that portlet may not be hooked up correctly to handle onclick events. The bug subscribers Windmill test is currently failing because of this.

Related branches

lp://qastaging/~deryck/launchpad/dupe-portlet-click-fail
Paul Hummer (community): Approve
Diff: 101 lines (+31/-5)
2 files modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+27/-3)
lib/lp/bugs/windmill/tests/test_bug_inline_subscriber.py (+4/-2)
Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 482379] Re: Unsubscribe icons in portlets may not handle onclick events

2009/11/13 Launchpad Bug Tracker <email address hidden>:
> ** Branch linked: lp:~deryck/launchpad/dupe-portlet-click-fail
>

I already have a fix for this in a branch that's ready to land. Up to
you which one we go with.

Revision history for this message
Deryck Hodge (deryck) wrote :

Ah, sorry, Graham. Didn't realize you had worked on this. What's the branch link?

Revision history for this message
Graham Binns (gmb) wrote :

2009/11/14 Deryck Hodge <email address hidden>:
> Ah, sorry, Graham.  Didn't realize you had worked on this.  What's the
> branch link?

I'll re-push and link it again shortly. If fixed it drive-by as part
of the subscriber timeout work, but I managed to screw up splitting
the branch up with pipelines on Friday night; I deleted it and forgot
to re-push.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9886 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9886>

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Deryck Hodge (deryck) wrote :

Graham, I merged my branch, just because I wanted to see if this would get jscheck green again, or if the fix would make any difference. And I knew I would get busy with UDS again tomorrow. Sorry that I duplicated work you already did.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 482379] Re: Unsubscribe icons in portlets may not handle onclick events

2009/11/15 Deryck Hodge <email address hidden>:
> Graham, I merged my branch, just because I wanted to see if this would
> get jscheck green again, or if the fix would make any difference.  And I
> knew I would get busy with UDS again tomorrow.  Sorry that I duplicated
> work you already did.

No worries; it was only a few lines in my branch anyway. Thanks for
taking care of it.

Diogo Matsubara (matsubara)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.