Replying to code review comments broken after YUI-3 upgrade
Bug #487209 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
The changes introduced to support YUI-3 final have broken code review comment replies via javascript.
Specifically, clicking the reply link will cause the error "Error: Y.one("label [for=field.vote]") is null
Source File: https:/
Line: 4873"
When reproducing this, be sure to reload the page after creating a comment. There is a buglet that the "reply" link of a created-
Related branches
lp://qastaging/~abentley/launchpad/fix-inline-reply
- Tim Penhey (community): Approve
-
Diff: 95 lines (+35/-12)2 files modifiedlib/canonical/launchpad/javascript/lp/comment.js (+5/-4)
lib/lp/code/windmill/tests/test_merge_proposal_commenting.py (+30/-8)
| tags: | added: code-review |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| milestone: | none → 3.1.11 |
| status: | New → In Progress |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Māris Fogels (mars) wrote | #1 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-devel revision 8729