Auto-claiming of reviews doesn't always work

Bug #488231 reported by Aaron Bentley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Tim Penhey

Bug Description

There are situations where a review request should be claimed, but is not. So far, I have been able to reproduce this by creating a review request with " " as the review type. This appears to have happened on https://code.edge.launchpad.net/~vila/bzr/releasing-clarified/+merge/10854, where the review request had None as its type, but ian's review had "" as its type.

Related branches

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 488231] [NEW] Auto-claiming of reviews doesn't always work

On Thu, 26 Nov 2009 03:30:00 Aaron Bentley wrote:
> Public bug reported:
>
> There are situations where a review request should be claimed, but is
> not. So far, I have been able to reproduce this by creating a review
> request with " " as the review type. This appears to have happened on
> https://code.edge.launchpad.net/~vila/bzr/releasing-
> clarified/+merge/10854, where the review request had None as its type,
> but ian's review had "" as its type.
>
> ** Affects: launchpad-code
> Importance: Medium
> Status: New
>
>
> ** Tags: code-review

The API through JS passes "" instead of None for empty form fields.

Tim Penhey (thumper)
Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
milestone: none → 3.1.11
status: New → Triaged
Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → Fix Committed
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.