Auto-claiming of reviews doesn't always work
Bug #488231 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
There are situations where a review request should be claimed, but is not. So far, I have been able to reproduce this by creating a review request with " " as the review type. This appears to have happened on https:/
Related branches
lp://qastaging/~thumper/launchpad/set-empty-review-type-as-none
- Michael Hudson-Doyle: Approve
-
Diff: 173 lines (+86/-31)2 files modifiedlib/lp/code/model/branchmergeproposal.py (+19/-7)
lib/lp/code/model/tests/test_branchmergeproposals.py (+67/-24)
Changed in launchpad-code: | |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 3.1.11 |
status: | New → Triaged |
Changed in launchpad-code: | |
status: | Triaged → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Thu, 26 Nov 2009 03:30:00 Aaron Bentley wrote: /code.edge. launchpad. net/~vila/ bzr/releasing- +merge/ 10854, where the review request had None as its type,
> Public bug reported:
>
> There are situations where a review request should be claimed, but is
> not. So far, I have been able to reproduce this by creating a review
> request with " " as the review type. This appears to have happened on
> https:/
> clarified/
> but ian's review had "" as its type.
>
> ** Affects: launchpad-code
> Importance: Medium
> Status: New
>
>
> ** Tags: code-review
The API through JS passes "" instead of None for empty form fields.