Release file for PPA contains nondescript "Label: Ubuntu"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Jelmer Vernooij |
Bug Description
According to <http://
However, the Release file for a PPA <http://
It would make more sense for the Label: header to be set to the displayname of the archive (e.g. "yorba" in this case).
Why this is important: For the Ubuntu Software Center, we want each PPA a user has added to have a sensible display name. It would be easier for the Center to find this information by parsing the Release file it has already read, than by using the Launchpad API to get the displayname for the archive.
(Security considerations: It is possible that someone could set the displayname of their PPA to "Ubuntu Official Updates" or similar. But (a) the Center will use the PPA icon for all PPAs, while it uses the Ubuntu or Canonical icons for official repositories; and (b) by the time you've added a nefarious PPA, you've already lost. We do not want to mention "Launchpad" or "PPA" in the label, because eventually users should be using PPAs without knowing that either Launchpad or PPAs exist.)
Related branches
- Julian Edwards (community): Approve (code)
-
Diff: 96 lines (+26/-8)2 files modifiedlib/lp/archivepublisher/publishing.py (+13/-2)
lib/lp/archivepublisher/tests/test_publisher.py (+13/-6)
Changed in soyuz: | |
status: | New → Triaged |
importance: | Undecided → Low |
assignee: | nobody → Jelmer Vernooij (jelmer) |
milestone: | none → 3.1.12 |
tags: | added: soyuz-publish trivial |
Changed in soyuz: | |
status: | Triaged → In Progress |
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
Fixed in devel r10002 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ devel/revision/ 10002>