Inline dupe finder does not show a form to submit a bug if no possible dups were found

Bug #495029 reported by Markus Korn
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns

Bug Description

Inline dupe finder does not show a form to submit a bureport is no possible dups were found, see the attached video as an example.
Just in case it is a javascript problem, I'm using firefox 3.5.5

This is confirmed for Chrome, too.

Related branches

Revision history for this message
Markus Korn (thekorn) wrote :
Markus Korn (thekorn)
summary: - Inline dupe finder does not show a form to submit a bureport is no
+ Inline dupe finder does not show a form to submit a bureport if no
possible dups were found
Graham Binns (gmb)
Changed in malone:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Graham Binns (gmb)
tags: added: confusing-ui
description: updated
Deryck Hodge (deryck)
summary: - Inline dupe finder does not show a form to submit a bureport if no
- possible dups were found
+ Inline dupe finder does not show a form to submit a bug if no possible
+ dups were found
tags: added: story-ajaxify-dupe-finder
Revision history for this message
Graham Binns (gmb) wrote :

This is due to the upgrade in YUI. The dupefinder was written and mostly QA'd against a branch which used the pre-release YUI3, which expected Y.all() to return null when no matching nodes were found. The released version of YUI3's Y.all() returns an empty NodeList when no nodes are found. Since the change for Y.Lang.isValue() on such results would now always return true, the JS assumed that there were duplicates found when there weren't and so would never show the filebug form in those cases.

The fix for this is to convert the Y.Lang.isValue() checks on the results of Y.all() to use result.size() > 0.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit
Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
Changed in malone:
milestone: none → 3.1.12
Deryck Hodge (deryck)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.