Launchpad itself

Konqueror does not display sprite for empty element (+edit, +editsshkey links)

Bug #521219 reported by Davor Cubranic on 2010-02-13

This bug report is a duplicate of: Bug #744808: image sprite is packed very asymmetrically - triggers poor rendering performance in firefox3 and missing icons in firefox4 and konquerer. Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Triaged	High	Unassigned

Bug Description

The 'change details' link in my Launchpad profile leads to a page (launchpad.net/~cubranic/+edit) where I can change my name and username, but not email address.

So what happens if I happen to change institutions and my email address changes, but I want to keep my Launchpad identity? Is there a way to change the address only?

ANALYSIS
The khtml engine will not render an png image that exceeds 16,300px. The launchpad sprite is greater than 20,000px. No browser promises to support an image that large. Though this issue currently affects Konqueror, it could effect other browsers because there is no mechanism to ensure the sprites are sensibly sized.

See original description

Tags:

Revision history for this message

William Grant (wgrant) wrote on 2010-02-13:

Try clicking the edit icon just above the email addresses on your profile page.

Changed in launchpad:
status:	New → Invalid

Revision history for this message

Davor Cubranic (cubranic) wrote on 2010-02-15:

launchpad-profile.png Edit (32.9 KiB, image/png)

There is no such icon: see attached screenshot. (Taken in Konqueror.)

Curtis Hovey (sinzui) on 2010-02-15

affects:	launchpad → launchpad-foundations
Changed in launchpad-foundations:
status:	Invalid → New
summary:	- Cannot change my email address + Konqueror does not display fmt:icon
tags:	added: css

Revision history for this message

Curtis Hovey (sinzui) wrote on 2010-02-15: Re: Konqueror does not display fmt:icon

The screenshot shows all the correct edit icons are misisng, only the hand crafter edit link is displayed:

The correct markup
    <a tal:replace="structure overview_menu/editemailaddresses/fmt:icon" />
creates text with calss=invisible-link (display: none):
    <a href="https://edge.launchpad.net/~user/+editemails"
   class="menu-link-editemailaddresses sprite edit"><span
    class="invisible-link">Change e-mail settings</span></a>
Which works well in gecko, webkit, presto, and trident based browsers.

We may want to explore anding a   outside of the hidden text so that there is something that takes up space.

Gary Poster (gary) on 2010-03-02

Changed in launchpad-foundations:
status:	New → Triaged
importance:	Undecided → Low

Jonathan Lange (jml) on 2010-03-12

affects:

launchpad-foundations → launchpad-web

Revision history for this message

Curtis Hovey (sinzui) wrote on 2010-11-05:

The tales formatters in python code are fixed. launchpad-inline-icon-link.txt need a nbsp inserted before the invisible-link:
> <span class="invisible-link"

tags:

added: trivial

Curtis Hovey (sinzui) on 2010-11-18

summary:	- Konqueror does not display fmt:icon + Konqueror does not display fmt:icon (sprite for empty element)
summary:	- Konqueror does not display fmt:icon (sprite for empty element) + Konqueror does not display sprite for empty element

Robert Collins (lifeless) on 2012-01-23

Changed in launchpad:
importance:	Low → High
summary:	- Konqueror does not display sprite for empty element + Konqueror does not display sprite for empty element (+edit, +editsshkey + links)

Revision history for this message

Curtis Hovey (sinzui) wrote on 2012-04-19:

I think the proper long term fix is to create multiple sprite files based on size of icon and the frequency of use. The icons beyond the range of khtml happen to be large icons and the newer small icons.