Launchpad itself

CopyChecker._checkArchiveConflicts erroneously permits copies of sources with failed and unpublished builds

Bug #527550 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

CopyChecker._checkArchiveConflicts rejects a copy if the candidate's build summary is BUILDING, NEEDSBUILD, or FULLYBUILT_PENDING. This lets FULLYBUILT and FAILEDTOBUILD through, which at first glance makes sense.

But looking at BuildSet.getStatusSummaryForBuilds we see that FAILEDTOBUILD takes precedence over FULLYBUILT(_PENDING). This means that if all builds have finished, but one or more have failed, a source-only copy will be erroneously permitted even if the successful builds have not yet been published. This probably leads to duplicate builds and missing binaries and other mess.

Revision history for this message
William Grant (wgrant) wrote :

This probably also affects the case of a binaryful copy if one or more builds have failed, one or more are unpublished, and one or more are published.

Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
tags: added: soyuz-core
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: none → 10.03
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 10.03 → pending
Robert Collins (lifeless)
summary: - CopyChecker._checkArchiveConflicts erroenously permits copies of sources
+ CopyChecker._checkArchiveConflicts erroneously permits copies of sources
with failed and unpublished builds
William Grant (wgrant)
tags: added: package-copies
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.