Launchpad itself

Rosetta import empty strings (e.g. "") from .po files

Bug #548375 reported by andbelo
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Данило Шеган
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

I downloaded a .po file for translation of a particular package, translated a few, ans imported the .po file back. As the result is imported all the empty strings ("") as suggested translations. I expected those empty strings translated would be ignored and only the non-empty used to update the previous translation of the package.

The big problem is that imported upstream translations are overwritten by user uploaded pofiles containing empty translations.

See original description
Revision history for this message
Данило Шеган (danilo) wrote :

Can you please give us the link to the page where these appear, and show us the PO file you uploaded? (FWIW, that shouldn't happen)

Changed in rosetta:
status: New → Incomplete
Revision history for this message
Данило Шеган (danilo) wrote :

Also, what option did you select on the upload: "Updated translation" or "Imported translation"?

Revision history for this message
andbelo (andbelo) wrote : Re: [Bug 548375] Re: Rosetta import empty strings (e.g. "") from .po files

I imported a .po file to the wiserearth project, however I don't remember
which option I selected as it was some days ago.

On Thu, Mar 25, 2010 at 7:18 PM, Данило Шеган <email address hidden> wrote:

> Also, what option did you select on the upload: "Updated translation" or
> "Imported translation"?
>
> --
> Rosetta import empty strings (e.g. "") from .po files
> https://bugs.launchpad.net/bugs/548375
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
andbelo (andbelo) wrote :

this is an example:
https://translations.launchpad.net/wiserearth/trunk/+pots/wiserearth/pt_BR/3331/+translate

On Fri, Mar 26, 2010 at 7:08 AM, André Beló <email address hidden> wrote:

> I imported a .po file to the wiserearth project, however I don't remember
> which option I selected as it was some days ago.
>
>
> On Thu, Mar 25, 2010 at 7:18 PM, Данило Шеган <email address hidden>wrote:
>
>> Also, what option did you select on the upload: "Updated translation" or
>> "Imported translation"?
>>
>> --
>> Rosetta import empty strings (e.g. "") from .po files
>> https://bugs.launchpad.net/bugs/548375
>> You received this bug notification because you are a direct subscriber
>> of the bug.
>>
>
>

Данило Шеган (danilo)
Changed in rosetta:
status: Incomplete → Invalid
status: Invalid → Incomplete
status: Incomplete → Triaged
importance: Undecided → High
tags: added: rosetta-imports
Revision history for this message
Данило Шеган (danilo) wrote :

We do have problems with importing empty strings (I reproduced it locally as well).

Adi Roiban (adiroiban)
Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
status: Triaged → In Progress
Revision history for this message
Данило Шеган (danilo) wrote :

You dropped out soon after you asked for my comments on the branch. So, it seems what you are doing is ignoring empty messages on *all* PO file imports. We should not do that, but do that only for "is_imported" or "is_published" ones (those coming from packages). You should be able to upload a PO file with no translation to unset a bad translation. I'd be even more interested to know how did this break, since that's how it used to work. The code for this was in updateTranslation() before.

Adi Roiban (adiroiban)
description: updated
Revision history for this message
Данило Шеган (danilo) wrote :

This is coming back all the time. Let's fix it so we don't have to worry about projects having work-arounds in place. Using the approach similar to what Adi did is probably best short term, but we should make sure we allow uploaded PO files by users to unset translations (as I commented above).

Changed in rosetta:
milestone: none → 10.09
Данило Шеган (danilo)
Changed in rosetta:
assignee: Adi Roiban (adiroiban) → Данило Шеган (danilo)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11501 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11501>.

tags: added: qa-needstesting
Changed in rosetta:
status: In Progress → Fix Committed
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.