publisher gets very unhappy about unknown distroreleases
Bug #55288 reported by
Colin Watson
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jelmer Vernooij | ||
Bug Description
Following the mistaken creation of dapper.0 and before we found somebody with DELETE privileges to get rid of it, the publisher crashed every time as follows:
10:07:57 DEBUG Finding distribution and distrorelease objects.
10:07:57 DEBUG Finding configuration.
10:07:57 ERROR No Lucille configuration section for dapper.0
It would be really good if "never heard of this distrorelease" were handled by skipping that distrorelease rather than crashing.
Related branches
lp://qastaging/~jelmer/launchpad/55288-publisher-unknown-distroseries
- Leonard Richardson (community): Approve (code)
-
Diff: 236 lines (+67/-28)4 files modifiedlib/lp/archivepublisher/config.py (+19/-14)
lib/lp/archivepublisher/ftparchive.py (+11/-3)
lib/lp/archivepublisher/tests/test_config.py (+19/-9)
lib/lp/archivepublisher/tests/test_ftparchive.py (+18/-2)
| Changed in soyuz: | |
| importance: | Untriaged → High |
| status: | Unconfirmed → Confirmed |
Revision history for this message
| Christian Reis (kiko) wrote | #1 |
| Changed in soyuz: | |
| importance: | High → Medium |
| Changed in soyuz: | |
| assignee: | nobody → cprov |
| importance: | Medium → High |
| milestone: | none → pending |
| status: | Confirmed → Triaged |
Revision history for this message
| Joey Stanford (joey) wrote | #2 |
Revision history for this message
| Celso Providelo (cprov) wrote | #3 |
| Changed in soyuz: | |
| assignee: | Celso Providelo (cprov) → nobody |
| tags: | added: soyuz-publisher |
| tags: | added: oops |
| Changed in soyuz: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #4 |
| tags: | added: qa-needstesting |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| milestone: | pending → 10.09 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Doing this is actually not as easy as it sounds. The reason is that the publisher assumes in many places that /all/ releases it is considering have lucille configs set up; we'd need to refactor some code to actually be able to do this. At any rate while this is bad it is also going to bite us only very rarely.