Result of SPRBuild assumes distro build
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Paul Hummer |
Bug Description
I think the real issue here is that source package releases only have urls in the distro context... There is no link for a source package release in a PPA context (they're listed on the ppa page, with details on the packages page), but:
1) View a completed SourcePackageRe
https:/
Note the Result: section which states: hello in ubuntu 2.5+1~lucid1 as a link with the src:
https:/
which 404s.
I think at the moment (as we don't support anything but PPA builds) this should not be linked. If you really did want to link it, I think the best link that could be provided currently would be: https:/
Related branches
- Robert Collins (community): Approve
-
Diff: 109 lines (+12/-19)4 files modifiedlib/lp/code/browser/tests/test_sourcepackagerecipe.py (+4/-14)
lib/lp/code/templates/branch-recipes.pt (+1/-1)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+7/-2)
lib/lp/code/templates/sourcepackagerecipebuild-index.pt (+0/-2)
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: recipe |
Changed in launchpad-code: | |
assignee: | nobody → Paul Hummer (rockstar) |
milestone: | none → 10.07 |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | Incomplete → In Progress |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
So the problem is that these objects sometimes have canonical url and sometimes don't. Is that a situation we want to perpetuate?
If these objects sometimes don't have canonical urls, then canonical_url should not return a URL sometimes.
Otherwise, we should just make sure the objects have URLs, which should be mostly a ZCML change.