Add confirmation dialog when marking duplicate a bug that itself has duplicates
Bug #591705 reported by
Deryck Hodge
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Deryck Hodge | ||
Bug Description
Now that a branch fixing bug 78596, Automatically handle moving duplicates across when duplicating a bug with dupes, is in review, we should add a confirmation dialog in the web UI when trying to mark duplicate a bug that itself has duplicates. The thinking is that undoing a mistake could be quite time consuming, so a "Are you sure you want to mark this bug and all it's duplicates as duplicates of XXX?" will call attention to the change.
This dialog will only be enabled for a bug that itself has duplicates.
Related branches
lp://qastaging/~deryck/launchpad/better-dupe-handling-ui
- Paul Hummer (community): Approve (ui)
- Matthew Revell (community): Approve (text)
- Aaron Bentley (community): Approve
-
Diff: 282 lines (+112/-17)6 files modifiedlib/canonical/launchpad/icing/style-3-0.css.in (+6/-0)
lib/lp/bugs/doc/bugactivity.txt (+41/-1)
lib/lp/bugs/javascript/bugtask_index.js (+38/-10)
lib/lp/bugs/model/bug.py (+7/-0)
lib/lp/bugs/templates/bug-portlet-actions.pt (+3/-3)
lib/lp/bugs/windmill/tests/test_mark_duplicate.py (+17/-3)
Revision history for this message
| Micah Gersten (micahg) wrote | #1 |
Revision history for this message
| Deryck Hodge (deryck) wrote | #2 |
| Changed in malone: | |
| status: | Triaged → In Progress |
| Changed in malone: | |
| milestone: | none → 10.08 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Deryck and I discussed this on LP and it would seem that some sort of limitation should be placed on who can do a multi-dupe move as the possibility of mistakes have a much greater impact than a single bug move. I created bug 591749 to allow for mass deduplication of bugs in case a mistake is made.