Launchpad itself

Remaining use of TranslationMessage.pofile

Bug #597539 reported by Jeroen T. Vermeulen
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Henning Eggers
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

With message sharing, TranslationMessage.pofile (among others) is obsolete. We still initialize it however, so we don't know how much we still rely on it.

As an experiment I set a bunch of TranslationMessage.pofile fields to null in the staging database, and watched what turned up later in the oops reports.

I caught a few in CurrentTranslationMessage.__init__:

        OOPS-1634S155, OOPS-1634S93
        OOPS-1634S156, OOPS-1634S94

The line that breaks is:

    current_translation_message.pofile.canEditTranslations(self.user))

The pofile itself isn't needed for that check AFAICS, but the project[group] or distribution owning it is. The view will have to gain some knowledge of the context it's viewing from, since that is no longer obvious from just the TranslationMessage.

Related branches

lp://qastaging/~henninge/launchpad/devel-bug-597539-translationmessage-pofile
Jeroen T. Vermeulen (community): Approve (code)
Diff: 1384 lines (+279/-572)
18 files modified
lib/lp/translations/browser/tests/translationmessage-views.txt (+6/-34)
lib/lp/translations/browser/translationmessage.py (+69/-42)
lib/lp/translations/doc/gettext-check-messages.txt (+9/-44)
lib/lp/translations/doc/pofile.txt (+1/-1)
lib/lp/translations/doc/potmsgset.txt (+5/-3)
lib/lp/translations/doc/remove-upstream-translations-script.txt (+0/-142)
lib/lp/translations/interfaces/pofile.py (+7/-0)
lib/lp/translations/interfaces/translationmessage.py (+6/-0)
lib/lp/translations/model/pofile.py (+37/-15)
lib/lp/translations/model/potmsgset.py (+0/-1)
lib/lp/translations/model/translationmessage.py (+11/-1)
lib/lp/translations/scripts/gettext_check_messages.py (+4/-29)
lib/lp/translations/templates/currenttranslationmessage-translate-one.pt (+12/-12)
lib/lp/translations/templates/translationmessage-translate.pt (+1/-1)
lib/lp/translations/tests/pofiletranslator.txt (+1/-12)
lib/lp/translations/tests/test_doc.py (+2/-6)
lib/lp/translations/tests/test_pofile.py (+108/-2)
scripts/rosetta/remove-upstream-translations.py (+0/-227)
Henning Eggers (henninge)
tags: added: message-sharing
Changed in rosetta:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Henning Eggers (henninge) wrote :

I just added an XXX to POFileTranslationActions.test_diverge_and_force_suggestion_mutual_exclusion in lp.translations.windmill.tests.test_pofile_translate that depends on this bug being fixed.

Revision history for this message
Henning Eggers (henninge) wrote :

... in the recife branch, that is.

Henning Eggers (henninge)
Changed in rosetta:
assignee: nobody → Henning Eggers (henninge)
milestone: none → 10.09
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11504 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11504>.

tags: added: qa-needstesting
Changed in rosetta:
status: In Progress → Fix Committed
Henning Eggers (henninge)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.