IProjectSet.search() has unused untested optional arguments
Bug #60055 reported by
James Henstridge
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
j.c.sackett | ||
Bug Description
Both IProductSet.
These arguments can be used via the productset and projectset views by URL hacking. For example:
https:/
However there is nothing in the page templates that would let a user do this (I think they used to be visible a long time ago). One of the following should be done:
* expose the checkboxes in the page templates, and add tests
* remove support for these constraints from the view classes and database classes
* remove support for these constraints from the view classes, but leave them in the DB classes and add tests.
Related branches
lp://qastaging/~jcsackett/launchpad/unused-args-search-60055
- Graham Binns (community): Approve (code)
-
Diff: 86 lines (+3/-35)3 files modifiedlib/lp/registry/browser/project.py (+1/-13)
lib/lp/registry/interfaces/projectgroup.py (+1/-4)
lib/lp/registry/model/projectgroup.py (+1/-18)
| Changed in launchpad: | |
| importance: | Untriaged → Low |
| status: | Unconfirmed → Confirmed |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in launchpad-registry: | |
| status: | Confirmed → Triaged |
Revision history for this message
| Barry Warsaw (barry) wrote | #2 |
| Changed in launchpad-registry: | |
| milestone: | none → 2.2.8 |
| assignee: | nobody → Barry Warsaw (barry) |
| Changed in launchpad-registry: | |
| milestone: | 2.2.8 → none |
| assignee: | Barry Warsaw (barry) → nobody |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #3 |
| Changed in launchpad-registry: | |
| milestone: | none → 3.1.10 |
| tags: |
added: infrastructure post-3-ui-cleanup removed: registry ui |
| tags: |
added: tech-debt removed: infrastructure |
| Changed in launchpad-registry: | |
| milestone: | 3.1.10 → none |
| tags: | removed: post-3-ui-cleanup |
Revision history for this message
| j.c.sackett (jcsackett) wrote | #5 |
| summary: |
- IProductSet.search() and IProjectSet.search() have unused untested - optional arguments + IProjectSet.search() has unused untested optional arguments |
| Changed in launchpad-registry: | |
| status: | Triaged → In Progress |
| assignee: | nobody → j.c.sackett (jcsackett) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #6 |
| Changed in launchpad-registry: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
For IProductSet, those arguments are also completely untested.
The entire test suite calls the method only in one place (bugtask-
Also, the rosetta argument produces invalid SQL: see bug 1415.