Timeouts on DistroSeries:+templates page
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
After we've fixed the "obvious" problems in bug #475435 with the page like
https:/
we are still getting timeouts. Good news is that the page sometimes loads, and we still have a few ideas on how we can improve it further.
Database is not a problem anymore, and we've reduced the time it takes to render it by removing repeated use of fmt:url in TAL and also got rid of the menu navigation for getting sub-pages which turned out to be *really* slow.
We are still doing a single fmt:url for each of the templates (every single row), and we can instead do string composition to construct URLs instead. The complication there is that each of the templates lives in a different sourcepackage, but that shouldn't be too hard to get. If that doesn't help, we can investigate using different TAL rendering libraries (like Chameleon, something Gary said we'll explore), and ultimately, fall back to batching.
What we should try first is doing just the simple string composition for URLs. In our tests that got the rendering time to a stable ~6s (which is still too much).
The new profiling stuff (see https:/
OOPS-1663ED2431 OOPS-1663EB2356 OOPS-1663EC2210
Related branches
- Aaron Bentley (community): Approve
- Launchpad code reviewers: Pending (code) requested
-
Diff: 716 lines (+500/-86)7 files modifiedlib/lp/translations/browser/distroseries.py (+9/-2)
lib/lp/translations/browser/potemplate.py (+142/-0)
lib/lp/translations/browser/productseries.py (+8/-2)
lib/lp/translations/browser/tests/test_seriestemplatesview.py (+332/-0)
lib/lp/translations/stories/standalone/xx-potemplate-edit.txt (+1/-3)
lib/lp/translations/stories/standalone/xx-series-templates.txt (+4/-8)
lib/lp/translations/templates/object-templates.pt (+4/-71)
Changed in rosetta: | |
assignee: | nobody → Adi Roiban (adiroiban) |
Changed in rosetta: | |
assignee: | Adi Roiban (adiroiban) → Jeroen T. Vermeulen (jtv) |
milestone: | none → 10.10 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
Do we still get timeouts on +templates, for project other than Ubuntu?
I guess that the previous fix is still a big improvement for all other projects, except Ubuntu.
Even with a faster TAL rendered, I think that we still need pagination for more than 300 templates.
Loading a page with more than 1000 templates, brings Chromium to his knees.
I will try to use Maris tips for generating a profile for +templates page.