delete team IntegrityError: emailaddress__person__key

The rules were not complete in the implementation. Adding a test for the email address of the merge team showed that it was transferred to ~registry. The fix is simple: call person.setContactAddress() /before/ doMerge() in DeleteTeamView.

Fixed in stable r11340 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11340>.

OOPS-1689EC2137 shows there is a new kind of oops:

  Module lp.registry.browser.peoplemerge, line 326, in merge_action
    self.context.setContactAddress(None)
  Module lp.registry.model.person, line 2052, in setContactAddress
    mailing_list_email = IMasterObject(mailing_list_email)
  Module zope.site.hooks, line 95, in adapter_hook
    return siteinfo.adapter_hook(interface, object, name, default)
  Module zope.security.adapter, line 88, in __call__
    adapter = self.factory(*args)
  Module canonical.launchpad.webapp.adapter, line 606, in get_object_from_master_store
    master_store = IMasterStore(obj)
TypeError: ('Could not adapt', None, <InterfaceClass canonical.launchpad.interfaces.lpstorm.IMasterStore>

The team had an mailing list. It was mark purged an hour before. I am surprised by this error:

        if self.mailing_list is not None:
            mailing_list_email = getUtility(IEmailAddressSet).getByEmail(
                self.mailing_list.address)
            mailing_list_email = IMasterObject(mailing_list_email)

I think the code may need to check if the mailing_list is purged to ensure it has an email address:
    if self.mailing_list is not None and self.mailing_list.status is not MailingListStatus.PURGED:

We will know this issue is fixed when we can delete https://launchpad.net/~ubuntu-l10n-nds