LaunchpadBrowserPublication.getApplication stashes site in LaunchBag

Bug #611542 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Michael Hudson-Doyle

Bug Description

LaunchpadBrowserPublication.getApplication() essentially caches its return value in the launchbag. As well as anything to do with the launchbag being a terrible idea, this means that you have to call getUtility(IOpenLaunchBag).clear() before calling it, making tests harder to write than they need to be.

I don't think any code depends on this being done, so we can probably just delete the code.

Related branches

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I have a branch that deletes this code running in ec2 already.

Changed in launchpad-foundations:
assignee: nobody → Michael Hudson (mwhudson)
status: New → In Progress
tags: added: tech-debt
Gary Poster (gary)
Changed in launchpad-foundations:
importance: Undecided → Low
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in launchpad-foundations:
milestone: none → 10.08
tags: added: qa-needstesting
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Stuart Bishop (stub)
tags: added: qa-untestable
removed: qa-needstesting
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.