Shipit dependencies on Launchpad should be isolated
Bug #616059 reported by
Brad Crittenden
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Brad Crittenden | ||
Bug Description
Shipit is now an external application to Launchpad but it maintains some dependencies that make it difficult for us to reorganize and refactor the code. We need to create a specific module that re-exports the items Shipit uses and then force it to only import from those spots. That allows us to move things around in the future without breaking Shipit.
Related branches
lp://qastaging/~bac/launchpad/bug-616059-shipit
- Paul Hummer (community): Approve (code)
-
Diff: 195 lines (+112/-4)4 files modifiedlib/canonical/launchpad/webapp/interaction.py (+1/-0)
lib/canonical/launchpad/webapp/tests/test_login.py (+13/-1)
lib/lp/scripts/utilities/importfascist.py (+4/-3)
lib/lp/shipit.py (+94/-0)
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
Revision history for this message
| Brad Crittenden (bac) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11333 <http://