archiveuploader blows up if Changed-By is missing in changes file
Bug #619157 reported by
Jelmer Vernooij
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
We rely on 'Changed-By' being set in a .changes file in various places, but don't actually check it is present during upload. If it isn't set, this causes KeyErrors (rather than UploadErrors) in the upload processor. It seems reasonable to require Changed-By for the time being, as all of the existing tools that generate .changes set it.
ChangesFile also doesn't have several fields as mandatory while they are mandatory according to Debian policy, some of which we rely on (in particular "Date"):
http://
I'll fix this as part of my test work for NascentUploadFile.
Related branches
lp://qastaging/~jelmer/launchpad/nascentuploadfile-tests
- Graham Binns (community): Approve (code)
-
Diff: 493 lines (+395/-13)5 files modifiedlib/lp/archiveuploader/changesfile.py (+11/-3)
lib/lp/archiveuploader/dscfile.py (+1/-0)
lib/lp/archiveuploader/nascentuploadfile.py (+6/-4)
lib/lp/archiveuploader/tests/test_changesfile.py (+134/-6)
lib/lp/archiveuploader/tests/test_nascentuploadfile.py (+243/-0)
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11400 <http://