Launchpad itself

Register project from source package should include homepage URL

Bug #621778 reported by Jelmer Vernooij
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned
Launchpad itself 10.12

Bug Description

A lot of Debian packages have the "Homepage" field set, which contains the upstream project homepage URL.

Now that the upstream project registration from a source package works, it should be possible to use this URL to automatically fill in the project homepage URL.

Related branches

lp://qastaging/~jelmer/launchpad/create-project-homepage
lp://qastaging/~jelmer/launchpad/621778-source-package-homepage (Merged)
lp://qastaging/~jelmer/launchpad/621778-homepage-field
Tim Penhey (community): Approve
Steve Kowalik (community): Approve (code*)
Stuart Bishop (community): Approve (db)
Robert Collins (community): Approve (db)
Diff: 269 lines (+80/-10)
13 files modified
database/schema/comments.sql (+2/-0)
database/schema/patch-2208-05-0.sql (+11/-0)
lib/lp/registry/interfaces/distroseries.py (+4/-1)
lib/lp/registry/model/distroseries.py (+3/-2)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+1/-1)
lib/lp/soyuz/interfaces/binarypackagerelease.py (+7/-0)
lib/lp/soyuz/interfaces/sourcepackagerelease.py (+8/-0)
lib/lp/soyuz/model/binarypackagebuild.py (+2/-2)
lib/lp/soyuz/model/binarypackagerelease.py (+1/-0)
lib/lp/soyuz/model/sourcepackagerelease.py (+1/-0)
lib/lp/soyuz/tests/test_binarypackagerelease.py (+16/-0)
lib/lp/soyuz/tests/test_sourcepackagerelease.py (+16/-0)
lib/lp/testing/factory.py (+8/-4)
lp://qastaging/~jelmer/launchpad/621778-parse-homepage-field
Jeroen T. Vermeulen (community): Approve (code)
Diff: 296 lines (+52/-26)
6 files modified
lib/lp/archiveuploader/dscfile.py (+2/-0)
lib/lp/archiveuploader/nascentuploadfile.py (+14/-14)
lib/lp/archiveuploader/tests/test_nascentuploadfile.py (+29/-7)
lib/lp/registry/browser/product.py (+3/-1)
lib/lp/registry/stories/product/xx-product-add.txt (+2/-2)
lib/lp/soyuz/tests/test_publishing.py (+2/-2)
lp://qastaging/~sinzui/launchpad/prefill-homepageurl-0
Māris Fogels (community): Approve
Diff: 266 lines (+74/-93)
3 files modified
lib/lp/registry/browser/sourcepackage.py (+6/-0)
lib/lp/registry/browser/tests/test_sourcepackage_views.py (+61/-66)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+7/-27)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

As this is one of my itches, I'll have a look at it.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I've linked a branch that adds the homepage field to the initial project registration.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

We removed the homepage field from registration last year because users thought this information was rarely relavent to registering their project. I am not certain we want to add it back for all registrations, but it is useful when registering from a source package or bug.

I'll wait to see your proposal. I too hate having to visit the Change details page to set one more piece of information.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Perhaps it would make sense to just show that field if a default value has been provided (such as by the registration from source package link). On the other hand I think putting extra magic in might make things confusing for users (a field being present in some situations but missing in others).

Another alternative would be to have a hidden field for the homepage and simply always use the URL that was present in the source package. Rethinking this, I think this is perhaps the best option if re-adding the homepage field is considered a bad idea. In almost all situations the value of the sourcepackage homepage will be correct, and if it isn't the user can always go to the details page to fix it.

What do you think?

Revision history for this message
Curtis Hovey (sinzui) wrote :

We often change the field_names attr to a property that decides whether to include the homepage it based on the registration condition.

I think adding the homepage to the registration form *is* an improvement, and we could restore it to the field names rgiht now. It was removed last year with several other links to external sties. The project page does not prompt the maintainer to provide links to external sties, but we intended to add an ajax overlay that allows the maintainer to add the links easilly to the project page. We have not commitments to do overlay now, so maintainers do not know about the external links fields.

So in summary. Lets add the field back. I do not expect users to complain about one more field.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in db-stable r9719 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9719>.

Changed in launchpad-registry:
milestone: none → 10.09
tags: added: qa-needstesting
Changed in launchpad-registry:
status: Triaged → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r9738 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9738>.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This hasn't actually been fixed yet - the two branches that have landed re-introduce the homepage field and make launchpad store the homepage field from packages.

Changed in launchpad-registry:
status: Fix Committed → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → High
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 10.09 → 10.10
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 10.10 → 10.11
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 10.11 → 10.12
Francis J. Lacoste (flacoste)
tags: added: bridging-the-gap
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: Jelmer Vernooij (jelmer) → Curtis Hovey (sinzui)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11971 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11971>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.