Launchpad itself

Deleting recipe leaves SourcePackageReleases with no traceability

Bug #645620 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Aaron Bentley
Launchpad itself 10.12

Bug Description

devel r11598 makes SourcePackageRecipe deletion nullify references on its SourcePackageReleases. This leaves us with a SourcePackageRelease for which we cannot determine an uploader. We really need to know who to blame.

Related branches

lp://qastaging/~abentley/launchpad/retain-spr-builds
Stuart Bishop (community): Approve (db)
Tim Penhey (community): Approve
Robert Collins: Pending (db) requested
Diff: 136 lines (+41/-15)
6 files modified
database/schema/patch-2208-28-0.sql (+7/-0)
lib/canonical/launchpad/security.py (+2/-1)
lib/lp/code/interfaces/sourcepackagerecipebuild.py (+1/-2)
lib/lp/code/model/sourcepackagerecipe.py (+3/-8)
lib/lp/code/model/sourcepackagerecipebuild.py (+1/-1)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+27/-3)
Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 645620] [NEW] Deleting recipe leaves SourcePackageReleases with no traceability

On Thu, 23 Sep 2010 10:23:45 you wrote:
> Public bug reported:
>
> devel r11598 makes SourcePackageRecipe deletion nullify references on
> its SourcePackageReleases. This leaves us with a SourcePackageRelease
> for which we cannot determine an uploader. We really need to know who to
> blame.
>
> ** Affects: launchpad-code
> Importance: Undecided
> Status: New

  importance high
  status triaged
  tag recipe

Changed in launchpad-code:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Tim Penhey (thumper) wrote :

What other ways can we have the traceability without keeping the recipe around? Where could we tag the build with useful information?

Changed in launchpad-code:
status: Triaged → Incomplete
Revision history for this message
William Grant (wgrant) wrote :

You can't tag the build, since that's what you're inappropriately deleting. If you want to delete all sorts of important stuff, you will need to add some new field to store this information.

Also, this bug is not Incomplete. All the information about the problem is here, we just need to work out a solution.

Tim Penhey (thumper)
Changed in launchpad-code:
status: Incomplete → Triaged
Revision history for this message
Aaron Bentley (abentley) wrote :

Our current idea is to make the recipe column on SourcePackageRecipeBuild nullable and change recipe deletion to null that field instead of deleting the build record. Since source package recipe build URLs include their recipe, this will make them unreachable from the web UI and web service, but they'll be in the database if you really need them. Sound good?

Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Aaron Bentley (abentley)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in db-stable r9979 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9979>.

Changed in launchpad-code:
milestone: none → 10.12
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Aaron Bentley (abentley)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.