BPPH.supersede shouldn't ever supersede obsolete or deleted publications

Bug #653395 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

IPublishing.supersede is meant to assert that the publication is Pending or Published. However, BinaryPackagePublishingHistory.supersede makes an exception for architecture-independent binaries.

While the idea behind this exception is sane (arch-indep binaries supersede each other atomically, so calling supersede() on a Superseded publication needs to be OK), it should ensure that the publication is Superseded. As it stands, it will mark a Deleted or Obsolete publication as Superseded -- but such a situation can only arise due to a bug, so it should crash and burn.

Related branches

Changed in soyuz:
status: New → Triaged
importance: Undecided → Medium
tags: added: soyuz-publisher
tags: added: soyuz-publish
removed: soyuz-publisher
Changed in launchpad:
importance: Medium → High
tags: added: trivial
tags: added: boobytrap tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.