Launchpad itself

Make it easy to select branch owner as recipe owner when creating recipe

Bug #670431 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Aaron Bentley
Launchpad itself 10.12

Bug Description

When I create a recipe, there are two natural choices as to who should own it:
  1. Me
  2. The owner of the branch I'm basing the recipe on

All of the other teams I'm in are very unlikely to actually be relevant. The UI for selecting recipe owner should make it easy to select either myself or the owner of the branch I'm basing the recipe on, perhaps in a way similar to selecting the target branch of a merge proposal.

Related branches

lp://qastaging/~abentley/launchpad/select-owner
Gavin Panella (community): Approve
Curtis Hovey (community): Approve (ui)
Guilherme Salgado (community): Approve (ui*)
Diff: 477 lines (+205/-108)
4 files modified
lib/canonical/widgets/suggestion.py (+169/-103)
lib/lp/code/browser/branch.py (+1/-1)
lib/lp/code/browser/sourcepackagerecipe.py (+2/-1)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+33/-3)
Revision history for this message
Aaron Bentley (abentley) wrote :

I assume you don't want people to be able to select the owner if they are not a member of the owner?

Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
status: Triaged → In Progress
Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 670431] Re: Make it easy to select branch owner as recipe owner when creating recipe

On Thu, Nov 4, 2010 at 7:04 PM, Aaron Bentley <email address hidden> wrote:
> I assume you don't want people to be able to select the owner if they
> are not a member of the owner?

Right.

Revision history for this message
Aaron Bentley (abentley) wrote :

If we're going to give suggestions, I wonder if branch.owner goes far enough? Won't some projects have packaging teams? Perhaps we should show members of branch.target.owner that have PPAs? Or what about owners of existing recipes for branch.target?

Revision history for this message
Aaron Bentley (abentley) wrote :

And should we omit the suggestions from the general list?

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11948 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11948>.

Changed in launchpad-code:
milestone: none → 10.12
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
Aaron Bentley (abentley)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.