Launchpad itself

Product:EntryResource:get_timeline timeline graph timeout on obsolete-junk project

Bug #671014 reported by Edwin Grubbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs
Launchpad itself 10.12

Bug Description

OOPS-1769S339

SQL time: 6252 ms
Non-sql time: 4630 ms
Total time: 10882 ms
Statement Count: 311

5. 3065 21ms SQL-launchpad-main-master SELECT Milestone.active, Milestone.codename, Milestone.dateexpected, Milestone.distribution, Milestone.distroseries, Milestone.id, Milestone.name, Milestone.product, Milestone.productseries, Milestone.summary FROM Milestone WHERE Milestone.productseries = %s ORDER BY milestone_sort_key(Milestone.dateexpected, Milestone.name) DESC LIMIT 20
6. 3089 18ms SQL-launchpad-main-master SELECT Milestone.active, Milestone.codename, Milestone.dateexpected, Milestone.distribution, Milestone.distroseries, Milestone.id, Milestone.name, Milestone.product, Milestone.productseries, Milestone.summary FROM Milestone WHERE Milestone.productseries = %s ORDER BY milestone_sort_key(Milestone.dateexpected, Milestone.name) DESC LIMIT 20

- its just bad repetitive code.

The https://staging.launchpad.net/obsolete-junk/+series page tries to load a timeline graph with all the obsolete series, which times out. Here is the API call that it is making:
https://staging.launchpad.net/api/devel/obsolete-junk?ws.op=get_timeline&include_inactive=true

The project +index page doesn't have this problem because its timeline graph does not include obsolete series.

See original description

Related branches

lp://qastaging/~edwin-grubbs/launchpad/bug-671014-timeline-graph-timeout
Curtis Hovey (community): Approve (code)
Diff: 854 lines (+309/-130)
15 files modified
lib/canonical/launchpad/javascript/client/client.js (+4/-2)
lib/canonical/launchpad/security.py (+9/-1)
lib/lp/registry/browser/configure.zcml (+11/-0)
lib/lp/registry/configure.zcml (+8/-0)
lib/lp/registry/interfaces/product.py (+5/-3)
lib/lp/registry/interfaces/productseries.py (+28/-0)
lib/lp/registry/interfaces/webservice.py (+5/-1)
lib/lp/registry/model/product.py (+21/-20)
lib/lp/registry/model/productseries.py (+20/-3)
lib/lp/registry/model/series.py (+10/-6)
lib/lp/registry/stories/webservice/xx-project-registry.txt (+57/-39)
lib/lp/registry/templates/object-timeline-graph.pt (+72/-29)
lib/lp/registry/templates/product-series.pt (+8/-4)
lib/lp/registry/templates/timeline-macros.pt (+19/-3)
lib/lp/registry/tests/test_product.py (+32/-19)
Curtis Hovey (sinzui)
tags: added: timeout
Robert Collins (lifeless)
summary: - timeline graph timeout on obsolete-junk project
+ Product:EntryResource:get_timeline timeline graph timeout on obsolete-
+ junk project
description: updated
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 10.11 → 10.12
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11994 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11994>.

tags: added: qa-needstesting
Changed in launchpad-registry:
status: In Progress → Fix Committed
Edwin Grubbs (edwin-grubbs)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.