review type field for merge proposal not always enabled
Bug #671665 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Ian Booth | ||
Bug Description
Now that a default reviewer is chosen when creating a merge proposal, the reviewer field is initially blank. The review type field is now also disabled until a reviewer has been chosen. Selecting a reviewer using the popup chooser doesn't enable the review type field. Workaround is to type and remove a character in the reviewer field.
Related branches
lp://qastaging/~wallyworld/launchpad/fix-enable-review-type
- Māris Fogels: Pending requested
-
Diff: 43 lines (+13/-2)2 files modifiedlib/lp/code/templates/branch-register-merge.pt (+1/-1)
lib/lp/code/windmill/tests/test_branchmergeproposal_review.py (+12/-1)
- Māris Fogels (community): Approve
-
Diff: 43 lines (+13/-2)2 files modifiedlib/lp/code/templates/branch-register-merge.pt (+1/-1)
lib/lp/code/windmill/tests/test_branchmergeproposal_review.py (+12/-1)
Revision history for this message
| Ian Booth (wallyworld) wrote | #1 |
Revision history for this message
| Ian Booth (wallyworld) wrote | #2 |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-code: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think that the root of the problem is that when the Person/Team selection popup is closed and the selected value inserted into the reviewer field, the reviewer field is not given focus. Hence there is no possibility to tab out of the field to trigger the onchange event. IMHO, typing the value directly or using a popup should result in the same end result - a populated field which has focus, thereby allowing subsequent event triggers to be properly processed.