Some valid failures in process-upload should not OOPS
Bug #673590 reported by
Ursula Junque
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Julian Edwards | ||
Bug Description
As seen in OOPS-1774FTPMASTER1:
EarlyReturnUp
This is a valid failure but should not oops.
Related branches
lp://qastaging/~julian-edwards/launchpad/reduce-oops-count-on-uploads-bug-673590
- Robert Collins (community): Approve
- Julian Edwards (community): Approve (code)
-
Diff: 57 lines (+18/-7)2 files modifiedlib/lp/archiveuploader/nascentupload.py (+17/-6)
lib/lp/archiveuploader/tests/nascentupload.txt (+1/-1)
lp://qastaging/~julian-edwards/launchpad/upload-early-return-oops
- Julian Edwards (community): Approve
-
Diff: 15 lines (+2/-2)1 file modifiedlib/lp/archiveuploader/uploadprocessor.py (+2/-2)
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: soyuz-upload |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| milestone: | none → 10.12 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #4 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Incremental fix | #5 |
| Changed in soyuz: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Robert Collins (lifeless) wrote | #6 |
| Changed in soyuz: | |
| status: | In Progress → Fix Released |
| status: | Fix Released → Fix Committed |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Some of the other OOPSes like OOPS-1782PPA118 are caused by the log level being an "error" in do_accept when it catches exceptions and logs them.
This needs to change so that if it's a QueueInconsiste