Properties wrapping usage columns should be dropped
Bug #677532 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
There are properties wrapping the database columns blueprints_usage, translations_usage, and answers_usage (as well as the column attributes on the model, _blueprint_usage &c).
Once all queries and other moving pieces have been updated to use usage enums and the properties are no longer necessary, we should remove them and promote _blueprint_usage et al to public attributes.
Related branches
lp://qastaging/~danilo/launchpad/bug-869089
- Benji York (community): Approve (code)
-
Diff: 874 lines (+84/-159)30 files modifieddatabase/sampledata/current.sql (+3/-3)
lib/canonical/launchpad/database/launchpadstatistic.py (+1/-5)
lib/lp/app/interfaces/launchpad.py (+0/-3)
lib/lp/registry/browser/distribution.py (+2/-2)
lib/lp/registry/browser/tests/distribution-views.txt (+2/-2)
lib/lp/registry/configure.zcml (+0/-2)
lib/lp/registry/doc/distribution.txt (+2/-4)
lib/lp/registry/interfaces/projectgroup.py (+3/-2)
lib/lp/registry/model/distribution.py (+3/-24)
lib/lp/registry/model/product.py (+4/-29)
lib/lp/registry/model/projectgroup.py (+1/-5)
lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt (+7/-5)
lib/lp/registry/tests/test_service_usage.py (+0/-21)
lib/lp/translations/browser/distribution.py (+1/-1)
lib/lp/translations/browser/potemplate.py (+2/-2)
lib/lp/translations/browser/tests/test_baseexportview.py (+1/-4)
lib/lp/translations/browser/tests/test_distroserieslanguage_views.py (+0/-1)
lib/lp/translations/browser/tests/test_product_view.py (+7/-5)
lib/lp/translations/browser/tests/test_productserieslanguage_views.py (+0/-2)
lib/lp/translations/browser/tests/test_translationimportqueueentry.py (+2/-1)
lib/lp/translations/browser/tests/test_translationlinksaggregator.py (+9/-4)
lib/lp/translations/doc/potmsgset.txt (+4/-3)
lib/lp/translations/interfaces/hastranslationtemplates.py (+4/-6)
lib/lp/translations/model/potemplate.py (+7/-6)
lib/lp/translations/model/translationsperson.py (+2/-2)
lib/lp/translations/scripts/tests/test_cache_suggestive_templates.py (+9/-6)
lib/lp/translations/scripts/translations_to_branch.py (+2/-2)
lib/lp/translations/stories/standalone/xx-series-templates.txt (+2/-1)
lib/lp/translations/tests/test_pofile.py (+0/-1)
lib/lp/translations/tests/test_shared_potemplate.py (+4/-5)
| Changed in launchpad-registry: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: tech-debt |
Revision history for this message
| Данило Шеган (danilo) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → Данило Шеган (danilo) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| status: | In Progress → Triaged |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| assignee: | Данило Шеган (danilo) → nobody |
To post a comment you must log in.
I am going to fix the official_rosetta related stuff.