Get rid of propose_goal_with_automatic_approval
Bug #680875 reported by
Guilherme Salgado
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Guilherme Salgado | ||
Bug Description
That functionality should be moved into model code to make sure goal proposals are always accepted when the proposer has the necessary rights.
Related branches
lp://qastaging/~salgado/launchpad/safe-blueprints-model
- Curtis Hovey (community): Approve (code)
- Jelmer Vernooij (community): Approve
-
Diff: 613 lines (+231/-80)15 files modifiedlib/canonical/launchpad/interfaces/launchpad.py (+7/-0)
lib/canonical/launchpad/security.py (+1/-3)
lib/lp/blueprints/browser/specification.py (+11/-32)
lib/lp/blueprints/configure.zcml (+2/-1)
lib/lp/blueprints/doc/specification.txt (+3/-2)
lib/lp/blueprints/errors.py (+19/-0)
lib/lp/blueprints/interfaces/specification.py (+29/-9)
lib/lp/blueprints/model/specification.py (+32/-23)
lib/lp/blueprints/model/sprint.py (+4/-3)
lib/lp/blueprints/tests/test_specification.py (+90/-0)
lib/lp/registry/model/distribution.py (+2/-1)
lib/lp/registry/model/hasdrivers.py (+22/-0)
lib/lp/registry/model/product.py (+2/-1)
lib/lp/registry/model/projectgroup.py (+2/-1)
lib/lp/registry/model/series.py (+5/-4)
| Changed in blueprint: | |
| status: | New → In Progress |
| assignee: | nobody → Guilherme Salgado (salgado) |
| Changed in blueprint: | |
| importance: | Undecided → High |
| milestone: | none → 10.12 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in blueprint: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in blueprint: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11976 <http://