Totally unrelated PPA referenced in subject of upload rejection email

Hmm, the email was complete with a totally bogus "X-Launchpad-PPA: trevormosey" header, too.

lpmain_staging=> select person.name from archive, person where purpose=2 and person.id = archive.owner order by archive.id limit 1 ;
    name
-------------
 trevormosey
(1 row)

This probably isn't a coincidence...

UploadProcessor.processChangesFile does this in the case that the PPA is not found:

            archive = distribution.getAllPPAs()[0]

On Fri, Dec 3, 2010 at 12:55 PM, William Grant <email address hidden> wrote:
> UploadProcessor.processChangesFile does this in the case that the PPA is
> not found:
>
>            archive = distribution.getAllPPAs()[0]

ROFL?!

On Thu, 2010-12-02 at 23:55 +0000, William Grant wrote:
> UploadProcessor.processChangesFile does this in the case that the PPA is
> not found:
>
> archive = distribution.getAllPPAs()[0]
Uhm, what!?

To be fair, it does have a XXX above it:

# XXX cprov 20071212: using the first available PPA is not exactly
# fine because it can confuse the code that sends rejection
# messages if it relies only on archive.purpose (which should be
# enough). On the other hand if we set an arbitrary owner it
# will break nascentupload ACL calculations.

It's really nasty that we have to wait with rejecting because we need a
NascentUpload object.

I would very much like to move the upload notifications into the
archiveuploader itself. This would also help with the fact that in some
cases the upload sends the notifications and in some cases the build.

Cheers,

Jelmer

I also received a bogus "Subject: [PPA trevormosey] ... rejected" when I typo'd my own username on a ppa upload ...

----------

From: Launchpad PPA <email address hidden>
Subject: [PPA trevormosey] linux_2.6.38-8.41+kamal~mjgbacklight3_source.changes rejected

Rejected:
Launchpad failed to process the upload path '~kamalmostaf/linux-kamal-mjgbacklight/ubuntu':

Could not find person or team named 'kamalmostaf'.

[...]

I just received an email with the subject "[PPA trevormosey] xxx rejected" when I provided an incorrect ppa name to dput.

I did however use the correct launchpad login.

While this is still a bug, we've hijacked the (deactivated and unused) account to make it more friendly in the meantime. Subject lines should now say:

[PPA invalid] xubuntu-meta_2.174_source.changes rejected

And the header is: X-Launchpad-PPA: invalid

This should cut down on the end user confusion.