Launchpad itself

Sync requester isn't credited with upload

Bug #827608 reported by Iain Lane
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Raphaël Badin

Bug Description

Packages copied using copyPackage don't appear on the requester's +uploaded-packages page. This is related to bug 827555, but this is for unsponsored syncs. The Signed-By field in the -changes announcement is correct, however.

Related branches

lp://qastaging/~rvb/launchpad/sync-bug-827608-spph-creator
j.c.sackett (community): Approve
Stuart Bishop (community): Approve (db)
Robert Collins: Pending requested
Diff: 896 lines (+417/-355)
4 files modified
database/sampledata/current-dev.sql (+201/-181)
database/sampledata/current.sql (+196/-174)
database/schema/comments.sql (+1/-0)
database/schema/patch-2208-82-1.sql (+19/-0)
lp://qastaging/~rvb/launchpad/sync-bug-827608-spph-creator-code
Brad Crittenden (community): Approve (code)
Diff: 205 lines (+56/-10)
6 files modified
lib/lp/soyuz/interfaces/publishing.py (+14/-2)
lib/lp/soyuz/model/publishing.py (+13/-4)
lib/lp/soyuz/scripts/packagecopier.py (+5/-3)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+21/-0)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+1/-0)
lib/lp/soyuz/tests/test_publishing.py (+2/-1)
lp://qastaging/~rvb/launchpad/sync-bug-827608-populate-ancestor
Brad Crittenden (community): Approve (code)
Diff: 32 lines (+10/-1)
2 files modified
lib/lp/soyuz/model/publishing.py (+1/-1)
lib/lp/soyuz/tests/test_publishing.py (+9/-0)
lp://qastaging/~rvb/launchpad/sync-bug-827608-credit-copy
Brad Crittenden (community): Approve (code)
Diff: 730 lines (+167/-124)
10 files modified
lib/lp/registry/browser/person.py (+32/-24)
lib/lp/registry/doc/person.txt (+19/-15)
lib/lp/registry/interfaces/person.py (+9/-7)
lib/lp/registry/model/person.py (+34/-18)
lib/lp/registry/templates/person-macros.pt (+10/-10)
lib/lp/registry/templates/person-related-software.pt (+17/-17)
lib/lp/soyuz/stories/soyuz/xx-person-packages.txt (+26/-13)
lib/lp/soyuz/templates/person-maintained-packages.pt (+4/-4)
lib/lp/soyuz/templates/person-ppa-packages.pt (+12/-12)
lib/lp/soyuz/templates/person-uploaded-packages.pt (+4/-4)
lp://qastaging/~rvb/launchpad/sync-bug-827608-credit-copy-2
William Grant (community): Approve (code)
Diff: 777 lines (+321/-106)
9 files modified
lib/lp/registry/browser/person.py (+2/-3)
lib/lp/registry/browser/tests/test_person_view.py (+71/-12)
lib/lp/registry/doc/person.txt (+35/-18)
lib/lp/registry/model/person.py (+36/-9)
lib/lp/registry/templates/person-macros.pt (+3/-3)
lib/lp/registry/templates/person-related-software.pt (+4/-4)
lib/lp/registry/tests/test_person.py (+106/-0)
lib/lp/soyuz/stories/soyuz/xx-person-packages.txt (+59/-52)
lib/lp/soyuz/templates/person-ppa-packages.pt (+5/-5)
lp://qastaging/~rvb/launchpad/sync-bug-827608-add-synchronized-packages
lp://qastaging/~rvb/launchpad/sync-bug-827608-spph-creator-code-redone
Gavin Panella (community): Approve
Diff: 205 lines (+56/-10)
6 files modified
lib/lp/soyuz/interfaces/publishing.py (+14/-2)
lib/lp/soyuz/model/publishing.py (+13/-4)
lib/lp/soyuz/scripts/packagecopier.py (+5/-3)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+21/-0)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+1/-0)
lib/lp/soyuz/tests/test_publishing.py (+2/-1)
lp://qastaging/~rvb/launchpad/sync-bug-827608-populate-ancestor-redone
Gavin Panella (community): Approve
Diff: 32 lines (+10/-1)
2 files modified
lib/lp/soyuz/model/publishing.py (+1/-1)
lib/lp/soyuz/tests/test_publishing.py (+9/-0)
lp://qastaging/~rvb/launchpad/sync-bug-827608-add-synchronized-packages-redone
Gavin Panella (community): Approve
Diff: 822 lines (+548/-14)
10 files modified
lib/lp/registry/browser/person.py (+116/-8)
lib/lp/registry/browser/tests/test_person_view.py (+149/-6)
lib/lp/registry/interfaces/person.py (+8/-0)
lib/lp/registry/model/person.py (+35/-0)
lib/lp/registry/templates/person-macros.pt (+62/-0)
lib/lp/registry/templates/person-related-software-navlinks.pt (+4/-0)
lib/lp/registry/templates/person-related-software.pt (+26/-0)
lib/lp/registry/tests/test_person.py (+83/-0)
lib/lp/soyuz/browser/configure.zcml (+6/-0)
lib/lp/soyuz/templates/person-synchronised-packages.pt (+59/-0)
Iain Lane (laney)
tags: added: derivation
Aaron Bentley (abentley)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Iain Lane (laney) wrote :

I just noticed I didn't get a build failure for the native sync I did. I guess that is another, more serious, effect of this same bug.

Julian Edwards (julian-edwards)
Changed in launchpad:
importance: Low → High
Raphaël Badin (rvb)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Raphaël Victor Badin (rvb)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r10964 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10964) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

2011-09-12 03:02:51 INFO 2208-82-1 applied just now in 6.4 seconds

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13997 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13997>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

This is bad, unfortunately:

261 query = """
262 - SELECT DISTINCT ON (upload_distroseries,
263 + SELECT DISTINCT ON (distroseries,
264 sourcepackagerelease.sourcepackagename,
265 - upload_archive)
266 + archive)

That means that a person's uploads are shown when copied between series and archives, even when not done by the uploader. If we exclusively used SPPH.creator this wouldn't be a problem, but until then we probably need to continue to use upload_distroseries and upload_archive for some cases.

Changed in launchpad:
status: Fix Committed → In Progress
tags: added: bad-commit-13997 qa-bad
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

This is visibly a problem on eg. ~wgrant/+uploaded-packages, where my few uploads to natty are shown several times (due to copy archives), and again in oneiric (because they were inherited from natty).

Rolled back in r13999.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

The intention of the change is that copying to a primary archive counts as an upload. I think the shitty sample data has clouded this issue in tests.

Revision history for this message
William Grant (wgrant) wrote :

The sampledata is beyond shitty, indeed. But I think this is actually the SPPHification of the old PackageUpload-based query being crap, not the new SPPH.creator-based query -- what was previously a DISTINCT over the upload archive and distroseries is now over the *publication* archive and distroseries.

This sort of thing is part of the reason I would have liked the branch to be split.

Revision history for this message
Raphaël Badin (rvb) wrote :

There is already two branches:
lp:~rvb/launchpad/sync-bug-827608-credit-copy does the SPPHification and nothing else
lp:~rvb/launchpad/sync-bug-827608-credit-copy-2 adds the new SPPH.creator-base query

Assuming that we want to keep the existing DISTINCT on spr.upload_*, we have the following dilemma:
- if we want to have a consistent display for the SPPHs from the old DISTINCT query, we need to use spr.upload_* in the display.
- if we want the new SPPHs (from the SPPH.creator-base query) to be displayed properly we need to use spph.distroseries and spph.archive.

Revision history for this message
Raphaël Badin (rvb) wrote :

Since most of the problems come from having to mix SPRs and SPPHs in the display, Julian and I decided to add a new slot on ~me/related-packages and a new page to display only the "Synchronised packages".

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14021 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14021>.

tags: added: qa-needstesting
removed: qa-bad
Changed in launchpad:
status: In Progress → Fix Committed
Raphaël Badin (rvb)
tags: added: qa-ok
removed: bad-commit-13997 qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Stefano Rivera (stefanor) wrote :

There's still no UI indication of the syncer on the source package version page or the API

Revision history for this message
Julian Edwards (julian-edwards) wrote :

The bug description says "Packages copied using copyPackage don't appear on the requester's +uploaded-packages page" and that was fixed here. If there are other places that need info, please file bugs!

Revision history for this message
Stefano Rivera (stefanor) wrote :

Thanks, was about to do that anyway. Filed as bug 861488

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.