Launchpad itself

The PPA page and distro publishing details pages don't correctly show where a package was copied from

Bug #851047 reported by Julian Edwards
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

Expanding a PPA package in the +packages page shows "Copied from XXX", as do pages like the distroseriessourcepackagerelease page which contain fragments of template from soyuz/templates/packagepublishing-details.pt. The current implementations always look at the upload_archive on the original sourcepackagerelease, which means that if the package was copied through an intermediate archive, the original archive is still incorrectly shown.

Now that the ancestor and creator columns are populated properly on the SourcePackagePublishingHistory, we can fix these messages so they show not only the correct previous context, but also who copied it.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

see https://launchpad.net/bilimbitest/angry/+source/aalib/1.4p5-38build1 for an example.

Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: ui ui-debt
Revision history for this message
Colin Watson (cjwatson) wrote :

SPPH.ancestor is set for new copies, but nobody has ever gone back to populate it for old ones. Worse, it briefly had a different meaning where each SPPH had it set to the previous version of the same package. Witness the chaos (where I assert that both these counts should be 0 if this transformation is going to be sensible):

launchpad_dogfood=# SELECT COUNT(*) FROM sourcepackagepublishinghistory spph, sourcepackagerelease spr WHERE spph.sourcepackagerelease = spr.id AND (spph.archive != spr.upload_archive OR spph.distroseries != spr.upload_distroseries) AND spph.ancestor IS NULL;
 count
--------
 809350
(1 row)

launchpad_dogfood=# SELECT COUNT(*) FROM sourcepackagepublishinghistory spph, sourcepackagerelease spr WHERE spph.sourcepackagerelease = spr.id AND spph.archive = spr.upload_archive AND spph.distroseries = spr.upload_distroseries AND spph.ancestor IS NOT NULL;
 count
-------
  4576
(1 row)

As a result I don't think ancestor can be used without some fairly substantial garbo job work to clean all this up. (I'm not volunteering.)

I'm handling the display of SPPH.creator as bug 1032857.

William Grant (wgrant)
tags: added: package-copies
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.