Spurious Changed-By fields in native-sync -changes email.

Bug #881476 reported by Stefano Rivera
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

Some [0] (but not all [1]) native-syncs -changes e-mail is subtly different from those generated by archive-admins. They include a Changed-By field, referencing the Debian uploader.
[0]: https://lists.ubuntu.com/archives/precise-changes/2011-October/000185.html
[1]: https://lists.ubuntu.com/archives/precise-changes/2011-October/000255.html
Both of those examples are native syncs, requested by me: https://launchpad.net/~stefanor/+synchronised-packages

For comparison:
Normally in Ubuntu -changes e-mail, Changed-By is the uploader [2], and for sponsored uploads, Signed-By is the sponsor [3].
[2]: https://lists.ubuntu.com/archives/precise-changes/2011-October/000786.html
[3]: https://lists.ubuntu.com/archives/precise-changes/2011-October/000787.html

For old, archive-admin syncs, we credited the requester in Changed-By for both regular and sponsored syncs [4] (a sponsored sync). The sponsor wasn't credited.
[4] https://lists.ubuntu.com/archives/precise-changes/2011-October/000794.html

There are currently tools that expect the old formats, such as the ubuntu-sponsoring stats (breakage in LP: #881288). They are now unable to differentiate between a sponsored upload [3], and native syncs [0].

I know we currently don't support sponsorship for native syncs (LP: #827555). However, I think we should be using Changed-By rather than Signed-By, and not report the Debian uploader at all.

Tags: derivation
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

From IRC (times in UTC):

(04:40:03) wgrant: So, lp.soyuz.adapter.notification will include Changed-By if it can find an email address.
(04:40:27) wgrant: It finds the email address using SPR.creator.preferredemail
(04:40:51) wgrant: Because gina is shit, SPR.creator for this SPR is actually the Maintainer field from the source package.
(04:41:05) wgrant: Looking in the DB, this is python-apps-team
(04:41:20) wgrant: Which no longer has the relevant email address, but must have when the SPR was created some time ago.
(04:41:30) wgrant: It no longer has any email address at all.
(04:41:33) wgrant: So there is no preferredemail.
(04:41:42) wgrant: So Changed-By doesn't show up in the email.
(04:42:03) wgrant: That explains the magical disappearing field.
(04:42:19) wgrant: And the rest is a matter for whoever is designing derivative distros.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Thanks for that explanation.

Changed in launchpad:
status: New → Triaged
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.