DBus Menu

Test "test-gtk-label" fails

Bug #1082516 reported by Mathieu Trudel-Lapierre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DBus Menu
Fix Released
Undecided
Charles Kerr

Bug Description

test-gtk-label fails to pass.

DBus daemon: unix:abstract=/tmp/dbus-NrqS72DsoX,guid=8f378af3f860230c7f11dd1250afe4c0
Client: Started with PID: 29701
Server: Started with PID: 29702
Xlib: extension "RANDR" missing on display ":101".

(lt-test-gtk-label-client:29701): Gtk-CRITICAL **: IA__gtk_icon_theme_has_icon: assertion `icon_name != NULL' failed

** (process:29702): ERROR **: Unable to get name 'glib.label.test' on DBus
FAIL: test-gtk-label
DBus daemon: unix:abstract=/tmp/dbus-ZPcDqhINbB,guid=6cb1dbbb7c3debb53cc394b050afe4d9
Client: Started with PID: 29765
Server: Started with PID: 29766
Xlib: extension "RANDR" missing on display ":101".
PASS: test-gtk-shortcut
DBus daemon: unix:abstract=/tmp/dbus-YonLdXBpLe,guid=03e67bca2296627db83e528250afe4e4
Client: Started with PID: 29821
Server: Started with PID: 29822
Xlib: extension "RANDR" missing on display ":101".
PASS: test-gtk-reorder
TEST: ./test-gtk-parser... (pid=29877)
Xlib: extension "RANDR" missing on display ":101".
  /dbusmenu/gtk/parser/base: OK
  /dbusmenu/gtk/parser/children: OK
PASS: ./test-gtk-parser
PASS: test-gtk-parser-test
==================================
1 of 15 tests failed
Please report to <email address hidden>
==================================

Related branches

lp://qastaging/~charlesk/libdbusmenu/lop-1082516
Mathieu Trudel-Lapierre: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 12 lines (+1/-1)
1 file modified
libdbusmenu-gtk/client.c (+1/-1)
lp://qastaging/ubuntu/raring-proposed/libdbusmenu
Charles Kerr (charlesk)
Changed in dbusmenu:
assignee: nobody → Charles Kerr (charlesk)
status: New → In Progress
Revision history for this message
Charles Kerr (charlesk) wrote :

Looks like the problem is coming from configuration #5 in test-gtk-label.json, specifically this entry:

 > {"id": 89,
 > "type": "standard",
 > "icon-name": "blank-icon",
 > "label": "blank"}

"blank-icon" is the magic string used by DBUSMENU_MENUITEM_ICON_NAME_BLANK, which in libdbusmenu-gtk/client.c is processed by image_property_handle() to give the menuitem a blank GtkImage.

In a subsequent call to image_property_handle() we call gtk_image_get_icon_name() on the existing image iff its storage type is GTK_IMAGE_ICON_NAME or GTK_IMAGE_EMPTY. This is legal use of that gtk function, but in the case listed above, the name that's returned is NULL, so we need to test for that before using icon_name elsewhere in image_property_handle().

Charles Kerr (charlesk)
Changed in dbusmenu:
status: In Progress → Fix Committed
Sebastien Bacher (seb128)
Changed in libdbusmenu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.