Adding a menu item without a label gets treated as a separator even if label is added later
Bug #1086563 reported by
Robert Ancell
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DBus Menu |
Fix Committed
|
High
|
Marco Trevisan (Treviño) | ||
libdbusmenu (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Trusty |
Fix Released
|
High
|
Unassigned |
Bug Description
* Impact
If you add a Gtk.MenuItem to an indicator menu without a label then appindicator treats the menu item like it is a separator (according to dbusmenu-dumper).
* Test case
Run this python script http://
* Regression potential
check that menus and indicators are correctly displayed
Related branches
lp://qastaging/~3v1n0/libdbusmenu/really-recreate-menu
- Charles Kerr (community): Approve
-
Diff: 11 lines (+1/-0)1 file modifiedlibdbusmenu-gtk/parser.c (+1/-0)
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 11 lines (+1/-0)1 file modifiedlibdbusmenu-gtk/parser.c (+1/-0)
Changed in libdbusmenu: | |
status: | New → In Progress |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
importance: | Undecided → High |
description: | updated |
summary: |
- Adding a menu item without a label and with a submenu gets treated as a - spearator even if label is added later + Adding a menu item without a label gets treated as a spearator even if + label is added later |
description: | updated |
Changed in libdbusmenu: | |
status: | In Progress → Fix Committed |
summary: |
- Adding a menu item without a label gets treated as a spearator even if + Adding a menu item without a label gets treated as a separator even if label is added later |
To post a comment you must log in.
I can see this is in dbusmenu libdbusmenu- gtk/parser. c:630: SEPARATOR_ MENU_ITEM (widget) || !find_menu_label (widget))
if (GTK_IS_
That logic is a bit off - not having a label doesn't make it a separator...