LinuxDC++

duplicate "finished uploads" listed

Bug #272972 reported by rosc2112
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
Fix Released
Low
Razzloss
LinuxDC++ 1.1.0

Bug Description

Not sure if this is strictly speaking a bug, but I do not recall this behavior in previous versions, so I'll assume it's a bug and not a feature unless informed otherwise :)

Completed uploads are being shown multiple times. with different sizes. I'm assuming they are partial/resumed uploads, but like I said, I don't know if that's how it should be.

Also, different issue, possibly a feature request, in older versions the "status" bar for transfers used to show useful info, now all it shows is the name of the hub. There's no longer any indications of what is going on with transfers, such as when a peer is full. Just seems to be a whole lot less info on the bottom window where transfers are shown.. Maybe this was all removed for a reason I am not aware of. Sorry also if this is the wrong place to discuss this :)

Revision history for this message
qwertitis (qwertitis-deactivatedaccount) wrote :

Thanks for your bug report. I can conclude that you are running the 0705 branch, but please declare what build you are using in future reports.

The bug is almost a duplicate of bug #208615.

Please remove the description of the other issue to a separate, new bug, as it is hard to track two requests in one bug.

Revision history for this message
Razzloss (razzloss) wrote :

Hmh, I don't really see anything 0705 specific here. Both issues occur with 0698 also, except that the status column has been fixed in the latest bzr of 0689 ( https://bugs.launchpad.net/linuxdcpp/+bug/257972 )

Multiple finished uploads appear because remote client requests different sized segments, this is a feature of the remote client not yours. Local client adds finished upload for every completed segment. Windows clients >705 group finished up/downloads under single row in a treeview. Maybe this will be the behaviour of the linuxDC++ also. Though I don't really see the point in reporting partially finished downloads* and grouping finished upload segments doesn't really make sense to me (ok, it reduces the number of lines in that view, but it still doesn't have to do anything with reality. Even if the row appears in your finished uploads it doesn't mean that the other end has completely downloaded the file).

*(it seems that latest windows clients have a feature to report only fully downloaded files)

And as individ said: One problem per bug report. Though in this case I believe that 2nd problem can be forgotten as it should be fixed already.

--RZ

Revision history for this message
rosc2112 (rosc2112) wrote :

Thanks for the explanation.

Seems I walked into a controversy with the segmented file requests, on my usual Rush DC Hub. They tell me segmented requests are bad and they block them in their clients. They tell me it hogs download slots and doesn't give them up. But then again, the complaints seem to be from people who don't want to share very much.

Revision history for this message
qwertitis (qwertitis-deactivatedaccount) wrote :

rosc2112, it is quite usual to hear that kind of complaint from hub owners, in fact, a great deal of hubs have banned the newer versions. Just switch to a hub that allow it. Also, I wish to apologize because I was mistaken about what branch you used.

qwertitis (qwertitis-deactivatedaccount)
Changed in linuxdcpp:
status: New → Incomplete
Steven Sheehy (steven-sheehy)
Changed in linuxdcpp:
status: Incomplete → New
Razzloss (razzloss)
Changed in linuxdcpp:
assignee: nobody → razzloss
importance: Undecided → Low
status: New → Fix Committed
Steven Sheehy (steven-sheehy)
Changed in linuxdcpp:
status: Fix Committed → Fix Released
Razzloss (razzloss)
Changed in linuxdcpp:
status: Fix Released → Fix Committed
Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

razzloss, was this actually fixed?

Changed in linuxdcpp:
milestone: none → 1.1.0
tags: added: finished-uploads ui
Revision history for this message
Razzloss (razzloss) wrote :

The feature mentioned in the title is atleast fixed. Before the finished transfers 'update' every finished chunk was added to the upload list. Now only the time and size transferred are updated for the later chunks. And IMO this makes more sense than to report only the 100% files in the finished uploads.

--RZ

Steven Sheehy (steven-sheehy)
Changed in linuxdcpp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.