whitespace other than space not treated as search word delimiter

Bug #275588 reported by qwertitis
0
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Undecided
Unassigned
LinuxDC++
Fix Released
Low
Unassigned

Bug Description

Reproduce:
1. Connect to your favourite hub
2. Search for `abba'. It returns results.
3. Now copy and paste ` abba' to your search field. (It's critical that the word is surrounded by some tab character)
4. The search returns no results since "\tabba" can't be found in any filename.

Expected behavior:
4. The search returns results regardless of what kind of whitespace is used.

Actual behavior:
Only space is used as a search word delimiter, even though tabs and newlines should be delimiters too (arguably).

Seen in 705 and 698, latest Linux DC++ bzr revisions.

Tags: core
Revision history for this message
qwertitis (qwertitis-deactivatedaccount) wrote :
Revision history for this message
qwertitis (qwertitis-deactivatedaccount) wrote :

This is a problem in DC++ (i.e. upstream) too? Here's a patch for lp:dcplusplus, not tested at all, so please don't be upset if it contains syntax errors. ^^'' Removed an unused(?) method too.

Changed in linuxdcpp:
assignee: nobody → individ
status: New → In Progress
Revision history for this message
Jacek Sieka (arnetheduck) wrote :

would be nice to support searches with significant whitespace (using for example " around a string) but that's another bug

Changed in dcplusplus:
status: New → Fix Committed
eMTee (realprogger)
Changed in dcplusplus:
status: Fix Committed → Fix Released
Changed in linuxdcpp:
importance: Undecided → Low
milestone: none → 1.1.0
status: In Progress → Fix Committed
Changed in linuxdcpp:
status: Fix Committed → Fix Released
tags: added: core
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.