Use system icons

Bug #406321 reported by David Prieto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
Fix Released
Medium
Unassigned

Bug Description

Linuxdcpp's visual integration would improve dramatically if it used system-set icons instead of its own custom ones. I'm attaching a quick mockup, showing some icons which are of course open to discussion.

Tags: ui
Revision history for this message
David Prieto (frandavid100-gmail) wrote :
Revision history for this message
Razzloss (razzloss) wrote :

This is already implemented in the main trunk.

--RZ

Changed in linuxdcpp:
importance: Undecided → Medium
milestone: none → 1.1.0
status: New → Fix Committed
Revision history for this message
Razzloss (razzloss) wrote :

or more accurately there's an option to use system icons.

--RZ

Revision history for this message
David Prieto (frandavid100-gmail) wrote :

Hi,

Could that option be enabled by default? Also, having the option NOT to use the system icons complicates the options menu, if just a bit. What are the advantages of having that option?

Revision history for this message
Razzloss (razzloss) wrote :

I guess the default should be to use system icons.

But in that case I think the option should be renamed to "Use custom icons" and that should default to 0.

--RZ

Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

I actually was going to switch to use system icons by default when I added SVG support, but I discovered it's not possible to have a stock icon to represent each of the icons we need. If you look at linuxdcpp with system icons turned on, you will see that some of the icons don't match exactly what they represent. You can read Gnome HIG and see that this is frowned upon. Also, I would like to add icons to represent a hub, private message and share browser but there is nothing even remotely close to match those in GTK+ stock icons. If we expand icons to include Gnome stock icons then we might find some, but we don't want to make linuxdcpp a gnome application. It is a GTK+ application.

I did add the themeable icon support at the same time I added SVG support, so people can always add their own themed icon by placing it in the proper directory. But besides that, not sure what to do here unless there is some magical set of icons I can use with any OS/desktop environment that I am unaware of.

Changed in linuxdcpp:
status: Fix Committed → Fix Released
tags: added: ui
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.