Multiple selection in user list

I don't have any problems with multiple user selection with the latest trunk. Of course it is possible that this has been implemented after the 1.0.3 release. So if you're using latest bzr trunk, please be a bit more specific.

--RZ

lys, you've reported numerous bugs in LinuxDC++ ... you should know better that you always have to include the version number you're using. Multiple selection in user list has been there for a long time (2006-11-22, to be exact). Multiple selection requires a combination of keyboard (ctrl or shift) and mouse to execute. Perhaps you're trying to do multiple select with mouse only?

sorry was doing 2 many things at once i forgot the version, its the Core version: 0.7091 i havent got exact bzr date as have modded the src quite a few times (minor cosmetic changes) and yes was only trying with the mouse, it just works with the mouse in windows upon trying with ctrl+shift it seems to work, sorry for the incomplete initial report

Added mouse multiple selection to all treeviews with multiple selection.

--RZ

This doesn't really seem to work consistently. If you left click a row, let go, then with mouse hovered over previously selected row hold down left mouse button and attempt to drag no selection box is shown and multiple rows are not selected. However, if you attempt to select multiple rows by starting the left click + drag at an unselected row it works fine. Favorite hubs just doesn't mouse multiple select at all. We may need to revisit the mouse button handling. Perhaps we are doing something wrong in the onButtonPressed or onButtonReleased.

Favorite hubs doesn't multiple select at all, so that disables rubber banding also.

But I'll check if there's something that can be done about the select+hover+drag problem.

--RZ

From GTK changelog:
2006-06-02 Kristian Rietveld <email address hidden>

 Rubber banding for GtkTreeView, #80127. Uses same method as
 GtkIconView.

 * gtk/gtktreeview.c (gtk_tree_view_class_init),
 (gtk_tree_view_init), (gtk_tree_view_get_property),
 (gtk_tree_view_set_property), (gtk_tree_view_set_rubber_banding),
 (gtk_tree_view_get_rubber_banding): add property,
 (gtk_tree_view_button_press): start rubber banding if enabled and
 press is on a non-selected node,
 (gtk_tree_view_button_release): stop rubber banding,
 (gtk_tree_view_motion_bin_window), (scrool_row_timeout): enable/update
 the rubber band,
 (gtk_tree_view_bin_expose): draw rubber band if active,
 (gtk_tree_view_stop_rubberband),
 (gtk_tree_view_update_rubber_band_selection_range),
 (gtk_tree_view_update_rubber_band_selection),
 (gtk_tree_view_update_rubber_band),
 (gtk_tree_view_paint_rubber_band): new functions.

It would seem that the rubber banding shouldn't work with already selected nodes. (At least I couldn't find anything in the changelog that would suggest that this has changed).

Should we rollback that change or leave as it is?

--RZ

I don't think it causes any regressions, so we can leave it. But we still need to decide whether or not it's a bug in linuxdcpp or gtk+.