Nag asks committers to merge without taking into account grace period
Bug #1293611 reported by
Sandy Carter (http://www.savoirfairelinux.com)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenERP Launchpad Community Utils |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
I have noticed this while checking the nag list:
As soon as an MP has 2 approves, it will suggest to merge it without taking into account the 3 day grace period described here:
http://
* A MP cannot be merged before 5 calendar days or 3 working days (based on this thread https:/
* That means the MP has at least 2 approved reviews
* But the 5 calendar / 3 working days rule can be lifted if a MP is approved by at least 3 reviewers
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | #1 |
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | #2 |
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | #3 |
| Changed in lp-community-utils: | |
| status: | New → Invalid |
To post a comment you must log in.
The final decision was 5 calendar days.
This 5 day grace period is supposed to be handled by the nag: http://
But it is broken since rev.30 ('age' has been removed)