Composing a machine should error if name contains underscore
Bug #1823265 reported by
Chris Johnston
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Newell Jensen | ||
Bug Description
When composing a machine, if I under a name that contains an underscore I am allowed to click 'Compose machine', however, the name is changed to a name provided by MAAS. This is an unexpected behaviour and would be better if an error were provided showing that you can't compose a machine with an underscore.
2.5.2 (7523-ge4ecbd54
Related branches
~newell-jensen/maas:api-raise-error-when-composing-machine-with-invalid-hostname
- Blake Rouse (community): Approve
- Andres Rodriguez (community): Needs Information
-
Diff: 48 lines (+18/-1)2 files modifiedsrc/maasserver/forms/pods.py (+3/-1)
src/maasserver/forms/tests/test_pods.py (+15/-0)
~newell-jensen/maas:lp1823265
- Andres Rodriguez (community): Approve
-
Diff: 52 lines (+17/-5)2 files modifiedsrc/maasserver/static/js/angular/controllers/pod_details.js (+2/-4)
src/maasserver/static/js/angular/controllers/tests/test_pod_details.js (+15/-1)
~steverydz/maas:compose-machine-validation
- Caleb Ellis (community): Approve
-
Diff: 95 lines (+23/-10)2 files modifiedsrc/maasserver/static/js/angular/controllers/pod_details.js (+17/-9)
src/maasserver/static/partials/pod-details.html (+6/-1)
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 2.6.0alpha2 |
| Changed in maas: | |
| milestone: | 2.6.0alpha2 → 2.6.0beta1 |
| tags: | added: ui |
| Changed in maas: | |
| milestone: | 2.6.0beta1 → 2.6.0beta2 |
Revision history for this message
| Andres Rodriguez (andreserl) wrote | #1 |
| Changed in maas: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
| Changed in maas: | |
| milestone: | 2.6.0beta2 → 2.6.0rc1 |
Revision history for this message
| Lilyana Videnova (lilyanavidenova) wrote | #2 |
Revision history for this message
| Andres Rodriguez (andreserl) wrote | #3 |
Revision history for this message
| Chris Johnston (cjohnston) wrote | #4 |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → New |
| Changed in maas: | |
| status: | New → In Progress |
Revision history for this message
| Newell Jensen (newell-jensen) wrote | #5 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | 2.6.0rc1 → 2.6.0beta4 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The solution should that the backend needs to validate that hostnames never use underscores.