Redfish powerdriver should be able to handle the reset power status

Bug #2079797 reported by Jacopo Rota
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Committed
High
Jacopo Rota
3.3
Fix Released
High
Seyeong Kim
3.4
Fix Released
High
Jacopo Rota
3.5
Fix Released
High
Jacopo Rota

Bug Description

Follow up from https://bugs.launchpad.net/maas/+bug/2004661.

In HPE Gen11 redfish returns also the status Reset even if it's outside the standard specification.

MAAS should be able to handle that, in particular it should wait until the BMC transitions to a known status ("poweroff", "poweron" for example).

Tags: sts

Related branches

Jacopo Rota (r00ta)
Changed in maas:
assignee: nobody → Jacopo Rota (r00ta)
status: New → In Progress
Changed in maas:
status: In Progress → Fix Committed
Seyeong Kim (seyeongkim)
tags: added: sts
Revision history for this message
Paul Jonason (pjonason) wrote :

Some feedback for future consideration (3.3. version, at least):

1. The Try/Retry counting is off
"This is the try number 0 out of 6"
"This is the try number 4 out of 6", then "Maximum number of retries reached"
MAX_REQUEST_RETRIES = 5
Why isn't MAX_REQUEST_RETRIES used in the log entry? It's hard coded to '6'.

2. Why does the code retry on ANY error in redfish_request, not just on returning transitional power statuses?
Could be get_etag, get_node_id, set_pxe_boot, or any power control, not just power_query
Could be permissions error or any other type of error.
So why retry a permissions error 6 times? It's still going to fail every time, and just waste time.

3. It doesn't appear to send back the error after the first instance, so it's hard to tell from the log what's actually going on:

maas.drivers.power.redfish: [info] Power action failure: Redfish request failed with response status code: 403.. This is the try number 0 out of 6.
maas.drivers.power.redfish: [info] Power action failure: [<twisted.python.failure.Failure builtins.ValueError: I/O operation on closed file.>]. This is the try number 1 out of 6.

What file? Who closed it? raise_error?

4. Spelling/grammar
"This is the try number..."
"Retring after %f seconds."

Revision history for this message
Jacopo Rota (r00ta) wrote :

For the record we just merged a patch that is fixing some redfish bugs https://bugs.launchpad.net/maas/+bug/2092172

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.