MAAS snap build pulls python modules from outside Ubuntu Archive / MAAS PPAs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Triaged
|
High
|
Unassigned | ||
3.2 |
Triaged
|
High
|
Unassigned | ||
3.3 |
Triaged
|
High
|
Unassigned | ||
3.4 |
Triaged
|
High
|
Unassigned | ||
3.5 |
Triaged
|
High
|
Unassigned |
Bug Description
Describe the bug:
---
During the MAAS snap build, python modules are installed from sources which are not the Ubuntu Archive or MAAS PPAs (e.g., pip), sometimes overriding previously installed packages from these sources.
This can lead to specific problems (e.g., in bug 2030814, a newer setuptools broke version number parsing in the snap build only, making even just `--help` fail; the deb build was fine).
But more importantly, this can lead to general problems to supportability and security:
- For example, if an issue/bug is found in such external dependencies, how to address/fix those (it might not be feasible to pull one by one into the MAAS PPAs).
- Another example are security vulnerabilities, as such external sources are not monitored/
Steps to reproduce:
---
Looking at some snap build logs in lp:~maas-committers (maas-master, maas-3.{5,4,3,2}), we see deb packages pulled at earlier versions, then pip installs at newer versions:
maas-master @ https:/
"""
Installing build-packages
...
[10/Dec/
...
Fetching stage-packages
...
[10/Dec/
...
Extracting stage package: python3-setuptools
...
:: + /build/
...
:: Downloading setuptools-
"""
maas-3.2 @ https:/
Get:33 http://
...
[25/Jul/
...
[25/Jul/
+ pip install -U pip setuptools wheel
...
Downloading setuptools-
+ pip install -U -r snap/local/
...
Downloading requests-
...
Downloading urllib3-
...
Expected behavior (what should have happened?):
---
All python modules used as build dependencies (or any build dependency) should be installed from sources that can be maintained/
Actual behavior (what actually happened?):
---
Some python modules are installed with 'pip', pulling in versions outside the Ubuntu Archive / MAAS PPAs, which can lead to specific problems as bug 2030814 (and other potential supportability/
MAAS version and installation type (deb, snap):
---
At least since maas 2.9.3 (bug 2030814), but also present in later maas builds (e.g., maas 3.2 to master, as in the build logs above).
MAAS setup (HA, single node, multiple regions/racks):
---
Not applicable (build-time).
Host OS distro and version:
---
Not applicable (build-time).
Additional context:
---
Internal document [1] (Jerzy has access), section 'DEB vs. SNAP build dependencies differences (and supportability)'
[1] https:/
Changed in maas: | |
status: | New → Triaged |
milestone: | none → 3.6.0 |
importance: | Undecided → High |
status: | Triaged → Fix Committed |
This was fixed in master/3.6 at 22811b1650b8361 6f2cbb2e3bb8229 50034aef3d