Applying storage layout does not always work for Allocated machines
Bug #1928623 reported by
Caleb Ellis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Committed
|
Medium
|
Peter Makowski | ||
| 3.4 |
Fix Committed
|
Undecided
|
Peter Makowski | ||
| maas-ui |
Fix Committed
|
Medium
|
Peter Makowski | ||
Bug Description
This is on 3.0.0~rc1 from the UI, calling the machine.
Applying a storage layout doesn't seem to work properly for "Allocated" machines - the disks are partitioned correctly but the partitions are not formatted or mounted anywhere. The websocket call is successful and there is no error reported. The machine ends up with `detected_
Related branches
~ack/maas:1928623-storage-layout-fs-allocated
- Björn Tillenius: Needs Information
- MAAS Lander: Needs Fixing
-
Diff: 216 lines (+57/-25)4 files modifiedsrc/maasserver/models/node.py (+1/-1)
src/maasserver/storage_layouts.py (+8/-3)
src/maasserver/tests/test_storage_layouts.py (+42/-14)
src/maasserver/utils/storage.py (+6/-7)
| Changed in maas: | |
| milestone: | none → 3.0.0-rc1 |
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Alberto Donato (ack) wrote | #1 |
| Changed in maas: | |
| assignee: | nobody → Alberto Donato (ack) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| milestone: | 3.0.0-rc1 → 3.0.1 |
| Changed in maas: | |
| status: | In Progress → Triaged |
| milestone: | 3.0.1 → none |
Revision history for this message
| Jerzy Husakowski (jhusakowski) wrote | #2 |
| Changed in maas: | |
| milestone: | none → 3.4.0 |
| tags: | added: ui |
| Changed in maas-ui: | |
| importance: | Undecided → Unknown |
| Changed in maas-ui: | |
| milestone: | none → 3.4.0 |
| importance: | Unknown → Medium |
| status: | New → Triaged |
| assignee: | nobody → Peter Makowski (petermakowski) |
Revision history for this message
| Thorsten Merten (thorsten-merten) wrote | #3 |
| Changed in maas: | |
| milestone: | 3.4.0 → 3.4.x |
| tags: | removed: ui |
Revision history for this message
| Peter Makowski (petermakowski) wrote | #4 |
Revision history for this message
| Peter Makowski (petermakowski) wrote | #5 |
Revision history for this message
| Peter Makowski (petermakowski) wrote | #6 |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas-ui: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Triaged |
| Changed in maas-ui: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | 3.4.x → 3.5.0 |
| status: | Triaged → Fix Committed |
| assignee: | Alberto Donato (ack) → Peter Makowski (petermakowski) |
To post a comment you must log in.
This affects API as well as UI.
If the machine is acquired, partition filesystems created from the storage layouts are not returned from "maas $profile partitions read"
The reason is the logic in maasserver.
A `BlockDevice` or `Partition` can have up to two `Filesystem` one with
`acquired` set to False and another set to `True`. When the `Node` for
`model` is in an allocated state the acquired `Filesystem` will be used
over the non-acquired `Filesystem`.
Filesystems created by storage layouts are never marked as acquired, so they're never returned if the machine is acquired.
I'm not exactly sure about the logic behind this, and whether this is intentional or a bug.