MAAS

Redfish in bmc-config commissioning script is hard-coded for a particular Manager and EthernetInterface

  1. Series 3.6
  2. Bug #2054836
Bug #2054836 reported by Paul Jonason
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Committed
Medium
Unassigned
MAAS 3.6.x
3.5
Won't Fix
Medium
Unassigned
3.6
Fix Committed
Medium
Unassigned
MAAS 3.6.x

Bug Description

Code within Redfish class's _get_bmc_ip in the bmc_config commissioning script looks to a specific url:
url = f"https://{self._redfish_ip}:{self._redfish_port}/redfish/v1/Managers/1/EthernetInterfaces/NIC"

But Manager IDs vary among bmc providers, as do the Manager EthernetInterfaces.

Related branches

~pjonason/maas:redfish-bmc-config-2054836
Alexsander de Souza: Approve
MAAS Lander: Approve
Diff: 352 lines (+237/-8)
2 files modified
src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py (+105/-7)
src/metadataserver/builtin_scripts/commissioning_scripts/tests/test_bmc_config.py (+132/-1)
Revision history for this message
Paul Jonason (pjonason) wrote :

Can't remember how to tie these together, but I do have code to propose to fix this in https://code.launchpad.net/~pjonason/maas/+git/maas/+ref/redfish-bmc-config-2054836

Revision history for this message
Paul Jonason (pjonason) wrote :

The proposed code finds the ID of the local Redfish Manager, then finds the collection of Manager EthernetInterfaces, and returns the IP address of the likely active Manager interface (that is, it will reject interfaces having an IP address of 0.0.0.0, 16.1.15.1, or anything starting with 169.254).

The ID of the local Manager was broken out into its own method so it can populate the node_id field in the Redfish power driver.

Also, I found a few bmcs return 201 on Session creation, so I included that in an array of acceptable return codes.

Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

Hi, I've created the Merge Proposal for you: https://code.launchpad.net/~pjonason/maas/+git/maas/+merge/462076

please check if this is correct and change its status to `Needs Review`

Changed in maas:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 3.5.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.